Bug 2665120: flex_string fatal error assigning big string to small

git-svn-id: svn://svn.code.sf.net/p/loki-lib/code/trunk@1007 7ec92016-0320-0410-acc4-a06ded1c099a

include/loki/flex/smallstringopt.h

@@ -220,17 +220,9 @@ public:
           new(this) SmallStringOpt(rhs);
         } else {
           SmallStringOpt copy(rhs);
-          if (Small()) {
-            // no need to swap, just destructively read copy into this
-            // ugly but efficient again
-            memcpy(this, &copy, sizeof(*this));
-            copy.buf_[maxSmallString] = maxSmallString; // clear the copy
-          } else {
-            // Use the swap trick
           copy.swap(*this);
         }
       }
-      }
       return *this;
     }