King_DuckZ/clooneljump
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix wrong increment of deleted iterator.

Browse source 
This fixes the invalid access spotted by valgrind.
This commit is contained in:
King_DuckZ 2016-10-31 19:51:52 +01:00
parent 09b41f6d0c
commit 09299595fe
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/observersmanager.hpp
View file

@ -140,8 +140,9 @@ namespace cloonel {
template <typename T> template <typename T>
void ObserversManager<T>::RemoveAll() noexcept { void ObserversManager<T>::RemoveAll() noexcept {
if (not m_tree.empty()) { if (not m_tree.empty()) {
for (typename TreeType::sibling_iterator it(m_tree.begin()), itEND(m_tree.end()); it != itEND; ++it) { for (typename TreeType::sibling_iterator it(m_tree.begin()), itEND(m_tree.end()); it != itEND;) {
const TicketType ticket = it->ticket; const TicketType ticket = it->ticket;
++it;
this->Remove(ticket); this->Remove(ticket);
} }
assert(m_tree.empty()); assert(m_tree.empty());