Stop using the do-nothing Path class.

Instead use the newly imported PhysicsFS through a wrapper.

CMakeLists.txt

@@ -15,6 +15,7 @@ include_directories(
 	src
 	include
 	"${PROJECT_BINARY_DIR}"
+	lib/physfs-2.0.3
 )
 
 configure_file(
@@ -22,6 +23,8 @@ configure_file(
 	"${PROJECT_BINARY_DIR}/${PROJECT_NAME}Config.h"
 )
 
+add_subdirectory(lib/physfs-2.0.3)
+
 add_executable(${PROJECT_NAME}
 	src/main.cpp
 	src/texture.cpp
@@ -31,9 +34,10 @@ add_executable(${PROJECT_NAME}
 	src/gamebase.cpp
 	src/character.cpp
 	src/placeable.cpp
-	src/path.cpp
+	src/physicsfswrapper.cpp
 )
 
 target_link_libraries(${PROJECT_NAME}
 	${SDL2_LIBRARIES}
+	physfs
 )

src/character.cpp

@@ -11,6 +11,14 @@ namespace cloonel {
 	{
 	}
 
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	Character::Character (const std::string&& parPath, SDLMain* parMain) :
+		Placeable(0.0f, 0.0f),
+		m_texture(new Texture(parPath, parMain, false))
+	{
+	}
+
 	///-------------------------------------------------------------------------
 	///-------------------------------------------------------------------------
 	Character::~Character() noexcept {

src/character.hpp

@@ -13,6 +13,7 @@ namespace cloonel {
 	class Character : public Placeable {
 	public:
 		Character ( const std::string& parPath, SDLMain* parMain );
+		Character ( const std::string&& parPath, SDLMain* parMain );
 		~Character ( void ) noexcept;
 
 		void Prepare ( void );

src/game.cpp

@@ -3,14 +3,14 @@
 
 namespace cloonel {
 	namespace {
-		const char g_characterTexture[] = "resources/graphics/duck.bmp";
+		const char g_characterTexture[] = "/resources/graphics/duck.bmp";
 	} //unnamed namespace
 
 	///------------------------------------------------------------------------
 	///------------------------------------------------------------------------
-	Game::Game (SDLMain* parSdlMain, const char* parBasePath) :
+	Game::Game (SDLMain* parSdlMain) :
-		GameBase(parSdlMain, parBasePath),
+		GameBase(parSdlMain),
-		m_character(new Character(m_path.GetFullPath(g_characterTexture), parSdlMain))
+		m_character(new Character(g_characterTexture, parSdlMain))
 	{
 	}
 

src/game.hpp

@@ -10,7 +10,7 @@ namespace cloonel {
 
 	class Game : public GameBase {
 	public:
-		Game ( SDLMain* parSdlMain, const char* parBasePath );
+		explicit Game ( SDLMain* parSdlMain );
 		virtual ~Game ( void ) noexcept;
 
 		virtual void Prepare ( void );

src/gamebase.cpp

@@ -23,8 +23,7 @@ namespace cloonel {
 
 	///------------------------------------------------------------------------
 	///------------------------------------------------------------------------
-	GameBase::GameBase (SDLMain* parSdlMain, const char* parBasePath) :
+	GameBase::GameBase (SDLMain* parSdlMain) :
-		m_path(parBasePath),
 		m_sdlmain(parSdlMain),
 		m_time0(SDL_GetTicks()),
 		m_wantsToQuit(false)

src/gamebase.hpp

@@ -1,7 +1,6 @@
 #ifndef id8C7FE975525B4329BFBEAF364D934EAD
 #define id8C7FE975525B4329BFBEAF364D934EAD
 
-#include "path.hpp"
 #include <memory>
 
 namespace cloonel {
@@ -14,14 +13,12 @@ namespace cloonel {
 		bool WantsToQuit ( void ) const;
 
 	protected:
-		GameBase ( SDLMain* parSdlMain, const char* parBasePath );
+		explicit GameBase ( SDLMain* parSdlMain );
 		virtual ~GameBase ( void ) noexcept;
 
 		virtual void Prepare ( void ) = 0;
 		virtual void Destroy ( void ) noexcept = 0;
 
-		const Path m_path;
-
 	private:
 		virtual void OnRender ( void ) = 0;
 		virtual void OnUpdate ( float parDelta ) = 0;

src/main.cpp

@@ -1,6 +1,7 @@
 #include "CloonelJumpConfig.h"
 #include "sdlmain.hpp"
 #include "game.hpp"
+#include "physicsfswrapper.hpp"
 #include <iostream>
 #include <stdexcept>
 #include <ciso646>
@@ -20,22 +21,31 @@ namespace {
 ///----------------------------------------------------------------------------
 ///following http://twinklebeardev.blogspot.co.uk/2012/07/lesson-1-hello-world.html
 ///----------------------------------------------------------------------------
-int main() {
+int main (int parArgc, char* parArgv[]) {
 	std::cout << GameName << " v" << GameVersionMajor << "." << GameVersionMinor << std::endl;
 
+	int retVal = 0;
 	cloonel::SDLMain sdlmain(GameName, DEF_WIN_WIDTH, DEF_WIN_HEIGHT);
 	try {
+#if defined(NDEBUG)
+		cloonel::PhysicsFSWrapper physfs(parArgc[0]);
+#else
+		cloonel::PhysicsFSWrapper physfs(GAME_BASE_PATH);
+#endif
+		physfs.Append("resources", "resources");
+
 		sdlmain.Init();
+
+		cloonel::Game game(&sdlmain);
+		game.Prepare();
+		RunMainLoop(game);
 	}
 	catch (const std::runtime_error& e) {
 		std::cerr << "Error during SDL2 initialization:\n";
 		std::cerr << e.what() << std::endl;
+		retVal = 1;
 	}
 
-	cloonel::Game game(&sdlmain, GAME_BASE_PATH);
-	game.Prepare();
-	RunMainLoop(game);
-
 	std::cout << "Quitting now" << std::endl;
-	return 0;
+	return retVal;
 }

src/path.cpp

@@ -1,49 +0,0 @@
-#include "path.hpp"
-#include <cassert>
-#include <sstream>
-#include <ciso646>
-
-namespace cloonel {
-	namespace {
-		///---------------------------------------------------------------------
-		///---------------------------------------------------------------------
-		std::string GetCleanBasePath (const std::string&& parPath) {
-			const size_t pathlen = parPath.size();
-			switch (pathlen) {
-			case 0:
-				return std::string("/");
-			case 1:
-				return parPath;
-			default:
-				if (parPath[pathlen - 1] == '/')
-					return parPath.substr(0, pathlen - 1);
-				else
-					return parPath;
-			}
-		}
-	} //unnamed namespace
-
-	///-------------------------------------------------------------------------
-	///-------------------------------------------------------------------------
-	Path::Path (const char* parBasePath) :
-		m_basePath(GetCleanBasePath(std::string(parBasePath)))
-	{
-	}
-
-	///-------------------------------------------------------------------------
-	///-------------------------------------------------------------------------
-	std::string Path::GetFullPath (const std::string& parPath) const {
-		std::ostringstream oss;
-		oss << m_basePath << '/' << parPath;
-		return oss.str();
-	}
-
-	///-------------------------------------------------------------------------
-	///-------------------------------------------------------------------------
-	std::string Path::GetFullPath (const char* parPath) const {
-		assert(parPath);
-		std::ostringstream oss;
-		oss << m_basePath << '/' << parPath;
-		return oss.str();
-	}
-} // namespace cloonel

src/path.hpp

@@ -1,20 +0,0 @@
-#ifndef id6B8B06CEFCED4E48A76E27CE5D65052F
-#define id6B8B06CEFCED4E48A76E27CE5D65052F
-
-#include <string>
-
-namespace cloonel {
-	class Path {
-	public:
-		explicit Path ( const char* parBasePath );
-		~Path ( void ) noexcept = default;
-
-		std::string GetFullPath ( const std::string& parPath ) const;
-		std::string GetFullPath ( const char* parPath ) const;
-
-	private:
-		const std::string m_basePath;
-	};
-} //namespace cloonel
-
-#endif

src/physicsfswrapper.cpp

@@ -0,0 +1,128 @@
+#include "physicsfswrapper.hpp"
+#include "physfs.h"
+#include <sstream>
+#include <stdexcept>
+#include <ciso646>
+#include <cassert>
+
+namespace cloonel {
+	namespace {
+		///---------------------------------------------------------------------
+		///---------------------------------------------------------------------
+		PHYSFS_File* OpenPhysFSFile (const char* parPath, PhysycsFSFile::OpenMode parMode) {
+			switch (parMode) {
+			case PhysycsFSFile::OpenMode_Read:
+				return PHYSFS_openRead(parPath);
+			case PhysycsFSFile::OpenMode_Write:
+				return PHYSFS_openWrite(parPath);
+			case PhysycsFSFile::OpenMode_Append:
+				return PHYSFS_openAppend(parPath);
+			default:
+				return nullptr;
+			}
+		}
+	} //unnamed namespace
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	PhysicsFSWrapper::PhysicsFSWrapper (const char* parBasePath) {
+		if (not PHYSFS_init(parBasePath)) {
+			std::ostringstream oss;
+			oss << "Error during PhysicsFS initialization: " << PHYSFS_getLastError();
+			throw std::runtime_error(oss.str());
+		}
+	}
+
+	///-------------------------------------------------------------------------
+	///Note that the deinit function could fail, but since we're in a dtor we
+	///are not checking in its return value as we can't throw anyways.
+	///-------------------------------------------------------------------------
+	PhysicsFSWrapper::~PhysicsFSWrapper() noexcept {
+		const bool succeeded = static_cast<bool>(PHYSFS_deinit());
+		assert(succeeded);
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	void PhysicsFSWrapper::Append (const char* parRelativePath, const char* parMountPoint) {
+		assert(parRelativePath);
+		assert(parMountPoint);
+		if (not PHYSFS_mount(parRelativePath, parMountPoint, 1)) {
+			std::ostringstream oss;
+			oss << "Error while adding \"" << parRelativePath <<
+				"\" to PhysicsFS' mount point \"" << parMountPoint << "\": ";
+			oss << PHYSFS_getLastError();
+			throw std::runtime_error(oss.str());
+		}
+	}
+
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	PhysycsFSFile::PhysycsFSFile (const char* parPath, OpenMode parMode, bool parBuffered, const char* parDescCategory) :
+		m_handle(OpenPhysFSFile(parPath, parMode))
+	{
+		if (not m_handle) {
+			std::ostringstream oss;
+			oss << "Error opening " << parDescCategory << " file: \"" <<
+			oss << parPath << "\": ";
+			oss << PHYSFS_getLastError();
+			throw std::runtime_error(oss.str());
+		}
+
+		if (parBuffered) {
+			//TODO: try to guess a buffer size
+			PHYSFS_setBuffer(static_cast<PHYSFS_File*>(m_handle), 1024);
+		}
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	PhysycsFSFile::~PhysycsFSFile() noexcept {
+		if (IsOpen()) {
+			PHYSFS_close(static_cast<PHYSFS_File*>(m_handle));
+		}
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	bool PhysycsFSFile::IsOpen() const noexcept {
+		return (m_handle != nullptr);
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	int64_t PhysycsFSFile::Read (void* parBuff, uint32_t parSize, uint32_t parCount) {
+		return PHYSFS_read(static_cast<PHYSFS_File*>(m_handle), parBuff, parSize, parCount);
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	int64_t PhysycsFSFile::Write (void* parBuff, uint32_t parSize, uint32_t parCount) {
+		return PHYSFS_write(static_cast<PHYSFS_File*>(m_handle), parBuff, parSize, parCount);
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	bool PhysycsFSFile::IsEof() const noexcept {
+		return PHYSFS_eof(static_cast<PHYSFS_File*>(const_cast<void*>(m_handle)));
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	int64_t PhysycsFSFile::Tell() const {
+		return PHYSFS_tell(static_cast<PHYSFS_File*>(const_cast<void*>(m_handle)));
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	int PhysycsFSFile::Seek (uint64_t parPos) {
+		return PHYSFS_seek(static_cast<PHYSFS_File*>(m_handle), parPos);
+	}
+
+	///-------------------------------------------------------------------------
+	///-------------------------------------------------------------------------
+	void PhysycsFSFile::Flush() noexcept {
+		PHYSFS_flush(static_cast<PHYSFS_File*>(m_handle));
+	}
+} //namespace cloonel

src/physicsfswrapper.hpp

@@ -0,0 +1,38 @@
+#ifndef idC54817CCCC0F454F931AE9082DFE9FDA
+#define idC54817CCCC0F454F931AE9082DFE9FDA
+
+#include <cstdint>
+
+namespace cloonel {
+	class PhysicsFSWrapper {
+	public:
+		explicit PhysicsFSWrapper ( const char* parBasePath );
+		~PhysicsFSWrapper ( void ) noexcept;
+
+		void Append ( const char* parRelativePath, const char* parMountPoint );
+	};
+
+	class PhysycsFSFile {
+	public:
+		enum OpenMode {
+			OpenMode_Read,
+			OpenMode_Write,
+			OpenMode_Append
+		};
+
+		PhysycsFSFile ( const char* parPath, OpenMode parMode, bool parBuffered, const char* parDescCategory );
+		~PhysycsFSFile ( void ) noexcept;
+
+		bool IsOpen ( void ) const noexcept;
+		int64_t Read ( void* parBuff, uint32_t parSize, uint32_t parCount );
+		int64_t Write ( void* parBuff, uint32_t parSize, uint32_t parCount );
+		bool IsEof ( void ) const noexcept;
+		int64_t Tell ( void ) const;
+		int Seek ( uint64_t parPos );
+		void Flush ( void ) noexcept;
+
+	private:
+		void* const m_handle;
+	};
+} // namespace cloonel
+#endif

src/texture.cpp

@@ -1,11 +1,22 @@
 #include "texture.hpp"
 #include "sdlerror.hpp"
 #include "sdlmain.hpp"
+#include "physicsfswrapper.hpp"
 #include <SDL2/SDL.h>
 #include <stdexcept>
 #include <cassert>
+#include <ciso646>
 
 namespace cloonel {
+	namespace {
+		///---------------------------------------------------------------------
+		///---------------------------------------------------------------------
+		SDL_Surface* LoadNewSurface (const std::string& parPath) {
+			assert(false);
+			return nullptr;
+		}
+	} //unnamed namespace
+
 	///------------------------------------------------------------------------
 	///------------------------------------------------------------------------
 	Texture::Texture (const std::string& parPath, SDLMain* parMain, bool parLoadNow) :