King_DuckZ/ducktorrent
1
0
Fork 0
Code Issues 7 Pull requests Projects Releases Packages Wiki Activity Actions

Make hashing algorithm more robust #8

New issue
Open
opened 2025-04-07 12:48:27 +00:00 by King_DuckZ · 0 comments
King_DuckZ commented 2025-04-07 12:48:27 +00:00
Owner
Copy link

Current hash verification in main.cpp is hacky and generally untidy. First of all that should become a bit cleaner. The main problem in terms of functionality is that it relies on the actual file size or even on each file existing in order to progress its chunk verification. Torrents with missing files will fail completely, instead it should use the size as provided by the torrent file and advance by as much for any missing chunk.

Current hash verification in main.cpp is hacky and generally untidy. First of all that should become a bit cleaner. The main problem in terms of functionality is that it relies on the actual file size or even on each file existing in order to progress its chunk verification. Torrents with missing files will fail completely, instead it should use the size as provided by the torrent file and advance by as much for any missing chunk.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
No results found.
Labels
Clear labels   
bug

   
enhancement

   
licence
No labels
bug
enhancement
licence
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: King_DuckZ/ducktorrent#8
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?