From b71dc805167cc583abb41cfd72b0b9ba10f95934 Mon Sep 17 00:00:00 2001 From: fgenesis Date: Sat, 2 Jun 2012 22:33:45 +0200 Subject: [PATCH 1/4] Correct OSX locale detection. (For me this returns en_de, not sure why, but i can see some german strings in my OSX installation here and there so this might be feasible.) Also fix typo in Network.cpp. --- Aquaria/Network.cpp | 2 +- Aquaria/UserSettings.cpp | 31 ++++++++++++++++++------------- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/Aquaria/Network.cpp b/Aquaria/Network.cpp index 5d09349..cc9f71d 100644 --- a/Aquaria/Network.cpp +++ b/Aquaria/Network.cpp @@ -103,7 +103,7 @@ protected: data->fp = fopen(data->tempFilename.c_str(), "wb"); if(!data->fp) { - fprintf(stderr, "SOCKET: Failed to save %u bytes, file not open"); + fprintf(stderr, "SOCKET: Failed to save %u bytes, file not open", size); data->fail = true; // TODO: and now? return; diff --git a/Aquaria/UserSettings.cpp b/Aquaria/UserSettings.cpp index 9d41677..9fadfde 100644 --- a/Aquaria/UserSettings.cpp +++ b/Aquaria/UserSettings.cpp @@ -40,7 +40,18 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #endif #ifdef BBGE_BUILD_MACOSX - #include + #include + #include + #include + +// veeery clunky. +static std::string _CFToStdString(CFStringRef cs) +{ + char buf[1024]; + CFStringGetCString(cs, &buf[0], 2048, kCFStringEncodingUTF8); + return &buf[0]; +} + #endif void UserSettings::save() @@ -647,30 +658,24 @@ void UserSettings::getSystemLocale() } #elif BBGE_BUILD_MACOSX CFLocaleRef locale = CFLocaleCopyCurrent(); - CFTypeRef type; + CFArrayRef langs = CFLocaleCopyPreferredLanguages(); CFStringRef buf; - type = CFLocaleGetValue(locale, kCFLocaleLanguageCode); - - if ((buf = CFLocaleCopyDisplayNameForPropertyValue(locale, kCFLocaleLanguageCode, type)) != NULL) + if ((buf = (CFStringRef)CFLocaleGetValue(locale, kCFLocaleLanguageCode)) != NULL) { - system.locale = buf; + system.locale = _CFToStdString(buf); CFRelease(buf); - CFRelease(type); - type = CFLocaleGetValue(locale, kCFLocaleCountryCode); - - if ((buf = CFLocaleCopyDisplayNameForPropertyValue(locale, kCFLocaleCountryCode, type)) != NULL) + if ((buf = (CFStringRef)CFArrayGetValueAtIndex(langs, 0)) != NULL) { system.locale += "_"; - system.locale += buf; + system.locale += _CFToStdString(buf); CFRelease(buf); } - - CFRelease(type); } CFRelease(locale); + CFRelease(langs); #else const char *lang = (const char *)getenv("LANG"); From af30e508f57ff7c46ad264f12af41012f8c600a4 Mon Sep 17 00:00:00 2001 From: fgenesis Date: Sat, 2 Jun 2012 23:06:53 +0200 Subject: [PATCH 2/4] Another correction, the prev. patch used the keyboard layout code, not country code. Misnamed APIs are awful. --- Aquaria/UserSettings.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Aquaria/UserSettings.cpp b/Aquaria/UserSettings.cpp index 9fadfde..a846737 100644 --- a/Aquaria/UserSettings.cpp +++ b/Aquaria/UserSettings.cpp @@ -658,7 +658,6 @@ void UserSettings::getSystemLocale() } #elif BBGE_BUILD_MACOSX CFLocaleRef locale = CFLocaleCopyCurrent(); - CFArrayRef langs = CFLocaleCopyPreferredLanguages(); CFStringRef buf; if ((buf = (CFStringRef)CFLocaleGetValue(locale, kCFLocaleLanguageCode)) != NULL) @@ -666,7 +665,7 @@ void UserSettings::getSystemLocale() system.locale = _CFToStdString(buf); CFRelease(buf); - if ((buf = (CFStringRef)CFArrayGetValueAtIndex(langs, 0)) != NULL) + if ((buf = (CFStringRef)CFLocaleGetValue(locale, kCFLocaleCountryCode)) != NULL) { system.locale += "_"; system.locale += _CFToStdString(buf); @@ -675,7 +674,7 @@ void UserSettings::getSystemLocale() } CFRelease(locale); - CFRelease(langs); + #else const char *lang = (const char *)getenv("LANG"); From 67bdd77a9ffb85dab8f38408cbb86062a5de4bc4 Mon Sep 17 00:00:00 2001 From: fgenesis Date: Wed, 13 Jun 2012 23:28:24 +0200 Subject: [PATCH 3/4] Attempting to fix weirdness from a bug report (thx!). This might speed up obstruction calculation a bit. Also fixed crash when attempting to autosave on an invalid map. --- Aquaria/Game.cpp | 155 ++++++++++++++++------------------------------- 1 file changed, 53 insertions(+), 102 deletions(-) diff --git a/Aquaria/Game.cpp b/Aquaria/Game.cpp index ced7ec4..1fa21df 100644 --- a/Aquaria/Game.cpp +++ b/Aquaria/Game.cpp @@ -1958,54 +1958,56 @@ void Game::clearObsRows() void Game::fillGridFromQuad(Quad *q, ObsType obsType, bool trim) { - /* - if (obsType == OT_INVISIBLEIN) - obsType = OT_INVISIBLE; - */ #ifdef BBGE_BUILD_OPENGL if (q->texture) { - std::vector obs, obsCopy; + std::vector obs; TileVector tpos(q->position); - //int tw = int((q->getWidth()*q->scale.x)/TILE_SIZE); - //int th = int((q->getHeight()*q->scale.y)/TILE_SIZE); - int w2 = int(q->getWidth()*q->scale.x)/2; - int h2 = int(q->getHeight()*q->scale.y)/2; + int widthscale = q->getWidth()*q->scale.x; + int heightscale = q->getHeight()*q->scale.y; + int w2 = widthscale/2; + int h2 = heightscale/2; w2/=TILE_SIZE; h2/=TILE_SIZE; tpos.x -= w2; tpos.y -= h2; GLuint id = q->texture->textures[0]; - float w, h, c=4; + int w = 0, h = 0; glBindTexture(GL_TEXTURE_2D, id); - glGetTexLevelParameterfv(GL_TEXTURE_2D, 0, GL_TEXTURE_WIDTH, &w); - glGetTexLevelParameterfv(GL_TEXTURE_2D, 0, GL_TEXTURE_HEIGHT, &h); - //glGetTexLevelParameterfv(GL_TEXTURE_2D, 0, GL_TEXTURE_COMPONENTS, &c);// assume 4 - int size = w*h*c; - unsigned char *data=0; - int sz = size*sizeof(unsigned char); - data = (unsigned char*)malloc(sz); - if (c == 4) - glGetTexImage(GL_TEXTURE_2D, 0, GL_RGBA, GL_UNSIGNED_BYTE, data); - else if (c == 3) - glGetTexImage(GL_TEXTURE_2D, 0, GL_RGB, GL_UNSIGNED_BYTE, data); - else + glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_WIDTH, &w); + glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_HEIGHT, &h); + //glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_COMPONENTS, &c);// assume 4 + int size = w*h*4; + if(size <= 0) + return; + unsigned char *data = (unsigned char*)malloc(size + 6); + memcpy(data + size, "SAFE", 5); + if (!data) { - if (data) - free(data); + errorLog("Game::fillGridFromQuad allocation failure"); + return; + } + glGetTexImage(GL_TEXTURE_2D, 0, GL_RGBA, GL_UNSIGNED_BYTE, data); + glBindTexture(GL_TEXTURE_2D, 0); + + // Not sure but this might be the case with nouveau drivers on linux... still investigating. -- fg + if(memcmp(data + size, "SAFE", 5)) + { + errorLog("Game::fillGridFromQuad(): Broken graphics driver! Wrote past end of buffer!"); + free(data); // in case we are here, this will most likely cause a crash. return; } - for (int tx = 0; tx < (q->getWidth()*q->scale.x); tx+=TILE_SIZE) + int szx = TILE_SIZE/q->scale.x; + int szy = TILE_SIZE/q->scale.y; + if (szx < 1) szx = 1; + if (szy < 1) szy = 1; + + for (int tx = 0; tx < widthscale; tx+=TILE_SIZE) { - for (int ty = 0; ty < (q->getHeight()*q->scale.y); ty+=TILE_SIZE) + for (int ty = 0; ty < heightscale; ty+=TILE_SIZE) { int num = 0; - int szx = TILE_SIZE/q->scale.x; - int szy = TILE_SIZE/q->scale.y; - if (szx < 1) szx = 1; - if (szy < 1) szy = 1; - for (int x = 0; x < szx; x++) { for (int y = 0; y < szy; y++) @@ -2016,19 +2018,14 @@ void Game::fillGridFromQuad(Quad *q, ObsType obsType, bool trim) int py = int(ty/q->scale.y) + y; if (px < w && py < h) { - if (c==3) - num++; + int p = (py*w*4) + px*4; + if (data[p+3] >= 254) + { + num ++; + } else { - int p = (py*w*c) + px*c; - if (data[p+3] >= 254) - { - num ++; - } - else - { - break; - } + break; } } } @@ -2044,18 +2041,21 @@ void Game::fillGridFromQuad(Quad *q, ObsType obsType, bool trim) } } + if (data) + { + free(data); + data = 0; + } if (trim) { - obsCopy = obs; + std::vector obsCopy = obs; obs.clear(); int sides = 0; - bool added; for (int i = 0; i < obsCopy.size(); i++) { sides = 0; - added = false; for (int j = 0; j < obsCopy.size(); j++) { if (i != j) @@ -2072,42 +2072,18 @@ void Game::fillGridFromQuad(Quad *q, ObsType obsType, bool trim) if (sides>=4) { obs.push_back(obsCopy[i]); - added = true; - //debugLog("added"); break; } } } - /* - if (!added) - { - debugLog("not added"); - } - */ } } - glBindTexture(GL_TEXTURE_2D, 0); - if (data) - free(data); - int rot = q->rotation.z; - while (rot > 360) - rot -= 360; - while (rot < 0) - rot += 360; - //rot = int(float(rot-45)/90.0f); - //int obsType = OT_INVISIBLEIN; + + glPushMatrix(); + for (int i = 0; i < obs.size(); i++) { - /* - Vector p = q->getWorldCollidePosition(Vector(obs[i].x-w2, obs[i].y-h2)); - TileVector tvec(tpos.x+w2+p.x, tpos.y+h2+p.y); - if (dsq->game->getGrid(tvec) == OT_EMPTY) - dsq->game->setGrid(tvec, obsType); - */ - - - glPushMatrix(); glLoadIdentity(); glRotatef(q->rotation.z, 0, 0, 1); @@ -2129,37 +2105,9 @@ void Game::fillGridFromQuad(Quad *q, ObsType obsType, bool trim) if (dsq->game->getGrid(tvec) == OT_EMPTY) dsq->game->setGrid(tvec, obsType); - glPopMatrix(); - - /* - // clockwise - if ((rot >= 0 && rot < 45) || rot >= 315) - { - // normal - dsq->game->setGrid(TileVector(tpos.x+obs[i].x, tpos.y+obs[i].y), obsType); - } - else if (rot >= 45 && rot < 135) - { - TileVector tpos(q->position); - tpos.x -= h2; - tpos.y -= w2; - dsq->game->setGrid(TileVector(tpos.x+(th-obs[i].y), tpos.y+obs[i].x), obsType); - } - else if (rot >= 135 && rot < 225) - { - // flip y - dsq->game->setGrid(TileVector(tpos.x+(tw-obs[i].x), tpos.y+(th-obs[i].y)), obsType); - } - else if (rot >= 225 && rot < 315) - { - TileVector tpos(q->position); - tpos.x -= h2; - tpos.y -= w2; - dsq->game->setGrid(TileVector(tpos.x+obs[i].y, tpos.y+(tw-obs[i].x)), obsType); - } - */ } - } + glPopMatrix(); + } #endif } @@ -5496,6 +5444,9 @@ bool Game::loadScene(std::string scene) void Game::saveScene(std::string scene) { + if (!this->saveFile) + return; + std::string fn = getSceneFilename(scene); TiXmlDocument saveFile(*this->saveFile); From a6fc88d88521fed947967ed85b2e05e936a2c296 Mon Sep 17 00:00:00 2001 From: fgenesis Date: Wed, 13 Jun 2012 23:37:21 +0200 Subject: [PATCH 4/4] Two little localzation patch additions, by Henrik Holst. --- Aquaria/AquariaSaveSlot.cpp | 6 +----- Aquaria/Continuity.cpp | 4 ++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/Aquaria/AquariaSaveSlot.cpp b/Aquaria/AquariaSaveSlot.cpp index d0f4fec..b311411 100644 --- a/Aquaria/AquariaSaveSlot.cpp +++ b/Aquaria/AquariaSaveSlot.cpp @@ -220,11 +220,7 @@ void AquariaSaveSlot::onUpdate(float dt) else if ((!core->mouse.buttons.left && !core->mouse.buttons.right) && mbDown) { mbDown = false; - if (text1->getText().find(dsq->continuity.stringBank.get(2003))!=std::string::npos && dsq->saveSlotMode == SSM_LOAD) - { - - } - else + if (!(empty && dsq->saveSlotMode == SSM_LOAD)) { selected = true; // pick this file diff --git a/Aquaria/Continuity.cpp b/Aquaria/Continuity.cpp index 2572966..71ac4e4 100644 --- a/Aquaria/Continuity.cpp +++ b/Aquaria/Continuity.cpp @@ -1200,11 +1200,11 @@ void Continuity::loadSongBank() songSlotNames.clear(); songBank.clear(); - loadIntoSongBank("data/songs.xml"); + loadIntoSongBank(dsq->user.localisePath("data/songs.xml")); if (dsq->mod.isActive()) { - loadIntoSongBank(dsq->mod.getPath() + "scripts/songs.xml"); + loadIntoSongBank(dsq->user.localisePath(dsq->mod.getPath() + "scripts/songs.xml", dsq->mod.getPath())); } }