From 0ed57f61b76170e378247edbd2557b789cdb93ad Mon Sep 17 00:00:00 2001 From: fig02 Date: Sun, 10 Dec 2023 14:53:51 -0500 Subject: [PATCH] Cleanup: Remove uneeded casts on collider members (#1595) * rm casts * format --- src/overlays/actors/ovl_En_Go2/z_en_go2.c | 4 ++-- src/overlays/actors/ovl_En_Ma1/z_en_ma1.c | 4 ++-- src/overlays/actors/ovl_En_Ma2/z_en_ma2.c | 4 ++-- src/overlays/actors/ovl_En_Ma3/z_en_ma3.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/overlays/actors/ovl_En_Go2/z_en_go2.c b/src/overlays/actors/ovl_En_Go2/z_en_go2.c index 51e8dcbb14..bc5c0b2203 100644 --- a/src/overlays/actors/ovl_En_Go2/z_en_go2.c +++ b/src/overlays/actors/ovl_En_Go2/z_en_go2.c @@ -1977,8 +1977,8 @@ void EnGo2_Update(Actor* thisx, PlayState* play) { EnGo2_SitDownAnimation(this); SkelAnime_Update(&this->skelAnime); EnGo2_RollForward(this); - Actor_UpdateBgCheckInfo(play, &this->actor, (f32)this->collider.dim.height * 0.5f, - (f32)this->collider.dim.radius * 0.6f, 0.0f, UPDBGCHECKINFO_FLAG_0 | UPDBGCHECKINFO_FLAG_2); + Actor_UpdateBgCheckInfo(play, &this->actor, this->collider.dim.height * 0.5f, this->collider.dim.radius * 0.6f, + 0.0f, UPDBGCHECKINFO_FLAG_0 | UPDBGCHECKINFO_FLAG_2); if (this->interactInfo.talkState == NPC_TALK_STATE_IDLE) { func_80A44AB0(this, play); } diff --git a/src/overlays/actors/ovl_En_Ma1/z_en_ma1.c b/src/overlays/actors/ovl_En_Ma1/z_en_ma1.c index df3425c7c9..ae75dfbd07 100644 --- a/src/overlays/actors/ovl_En_Ma1/z_en_ma1.c +++ b/src/overlays/actors/ovl_En_Ma1/z_en_ma1.c @@ -350,7 +350,7 @@ void EnMa1_IdleTeachSong(EnMa1* this, PlayState* play) { this->interactInfo.talkState = NPC_TALK_STATE_TALKING; this->actor.flags |= ACTOR_FLAG_16; this->actionFunc = EnMa1_StartTeachSong; - } else if (this->actor.xzDistToPlayer < 30.0f + (f32)this->collider.dim.radius) { + } else if (this->actor.xzDistToPlayer < 30.0f + this->collider.dim.radius) { player->stateFlags2 |= PLAYER_STATE2_23; } } @@ -401,7 +401,7 @@ void EnMa1_Update(Actor* thisx, PlayState* play) { this->actionFunc(this, play); if (this->actionFunc != EnMa1_DoNothing) { - Npc_UpdateTalking(play, &this->actor, &this->interactInfo.talkState, (f32)this->collider.dim.radius + 30.0f, + Npc_UpdateTalking(play, &this->actor, &this->interactInfo.talkState, this->collider.dim.radius + 30.0f, EnMa1_GetTextId, EnMa1_UpdateTalkState); } diff --git a/src/overlays/actors/ovl_En_Ma2/z_en_ma2.c b/src/overlays/actors/ovl_En_Ma2/z_en_ma2.c index 16f6eec8c7..c8bb777538 100644 --- a/src/overlays/actors/ovl_En_Ma2/z_en_ma2.c +++ b/src/overlays/actors/ovl_En_Ma2/z_en_ma2.c @@ -268,7 +268,7 @@ void func_80AA204C(EnMa2* this, PlayState* play) { player->stateFlags2 |= PLAYER_STATE2_25; Message_StartOcarina(play, OCARINA_ACTION_CHECK_EPONA); this->actionFunc = func_80AA20E4; - } else if (this->actor.xzDistToPlayer < 30.0f + (f32)this->collider.dim.radius) { + } else if (this->actor.xzDistToPlayer < 30.0f + this->collider.dim.radius) { player->stateFlags2 |= PLAYER_STATE2_23; } } @@ -319,7 +319,7 @@ void EnMa2_Update(Actor* thisx, PlayState* play) { func_80AA1DB4(this, play); func_80AA1AE4(this, play); if (this->actionFunc != func_80AA20E4) { - Npc_UpdateTalking(play, &this->actor, &this->interactInfo.talkState, (f32)this->collider.dim.radius + 30.0f, + Npc_UpdateTalking(play, &this->actor, &this->interactInfo.talkState, this->collider.dim.radius + 30.0f, EnMa2_GetTextId, EnMa2_UpdateTalkState); } } diff --git a/src/overlays/actors/ovl_En_Ma3/z_en_ma3.c b/src/overlays/actors/ovl_En_Ma3/z_en_ma3.c index 03af656731..e769d93669 100644 --- a/src/overlays/actors/ovl_En_Ma3/z_en_ma3.c +++ b/src/overlays/actors/ovl_En_Ma3/z_en_ma3.c @@ -297,7 +297,7 @@ void EnMa3_Update(Actor* thisx, PlayState* play) { EnMa3_UpdateEyes(this); this->actionFunc(this, play); func_80AA2E54(this, play); - Npc_UpdateTalking(play, &this->actor, &this->interactInfo.talkState, (f32)this->collider.dim.radius + 150.0f, + Npc_UpdateTalking(play, &this->actor, &this->interactInfo.talkState, this->collider.dim.radius + 150.0f, EnMa3_GetTextId, EnMa3_UpdateTalkState); if (this->interactInfo.talkState == NPC_TALK_STATE_IDLE) { if (this->isNotSinging) {