Reduce dependencies on global.h (9) (#2488)

* split game states

* split all GameState headers

* match fig names

* deduplicate headers from bad merge

* split z64actor.h into z64actor_profile.h, z_actor_dlftbls.h

* fix compile error

* .bss

src/code/fault_gc.c

@@ -40,8 +40,8 @@
  * DPad-Up may be pressed to enable sending fault pages over osSyncPrintf as well as displaying them on-screen.
  * DPad-Down disables sending fault pages over osSyncPrintf.
  */
-#pragma increment_block_number "gc-eu:160 gc-eu-mq:160 gc-eu-mq-dbg:160 gc-jp:160 gc-jp-ce:160 gc-jp-mq:160 gc-us:160" \
-                               "gc-us-mq:160 ique-cn:160"
+#pragma increment_block_number "gc-eu:160 gc-eu-mq:160 gc-eu-mq-dbg:160 gc-jp:176 gc-jp-ce:176 gc-jp-mq:176 gc-us:176" \
+                               "gc-us-mq:176 ique-cn:176"
 
 #include "global.h"
 #include "libc64/sleep.h"

src/code/graph.c

@@ -2,8 +2,8 @@
 #include "libc64/sprintf.h"
 #include "libu64/debug.h"
 
-#include "console_logo_state.h"
 #include "buffers.h"
+#include "console_logo_state.h"
 #include "gfx.h"
 #include "fault.h"
 #include "file_select_state.h"
@@ -14,10 +14,11 @@
 #include "regs.h"
 #include "setup_state.h"
 #include "sys_ucode.h"
-#include "title_setup_state.h"
 #include "terminal.h"
+#include "title_setup_state.h"
 #include "ucode_disas.h"
 #include "versions.h"
+#include "z_game_dlftbls.h"
 #include "z64save.h"
 #include "z64play.h"
 

src/code/main.c

@@ -28,8 +28,8 @@ extern struct IrqMgr gIrqMgr;
 
 #include "global.h"
 
-#pragma increment_block_number "gc-eu:144 gc-eu-mq:144 gc-jp:144 gc-jp-ce:144 gc-jp-mq:144 gc-us:144 gc-us-mq:144" \
-                               "ique-cn:144 ntsc-1.0:129 ntsc-1.1:129 ntsc-1.2:129 pal-1.0:127 pal-1.1:127"
+#pragma increment_block_number "gc-eu:160 gc-eu-mq:160 gc-jp:160 gc-jp-ce:160 gc-jp-mq:160 gc-us:160 gc-us-mq:160" \
+                               "ique-cn:160 ntsc-1.0:140 ntsc-1.1:140 ntsc-1.2:140 pal-1.0:138 pal-1.1:138"
 
 extern u8 _buffersSegmentEnd[];
 

src/code/title_setup.c

@@ -1,7 +1,7 @@
+#include "console_logo_state.h"
 #include "setup_state.h"
 
 #include "global.h"
-#include "console_logo_state.h"
 
 void Setup_InitImpl(SetupState* this) {
     PRINTF(T("ゼルダ共通データ初期化\n", "Zelda common data initialization\n"));

src/code/z_DLF.c

@@ -1,7 +1,10 @@
+#include "libc64/malloc.h"
 #include "libu64/overlay.h"
-
-#include "global.h"
 #include "terminal.h"
+#include "ultra64.h"
+#include "z_game_dlftbls.h"
+
+#include "macros.h"
 
 void Overlay_LoadGameState(GameStateOverlay* overlayEntry) {
     if (overlayEntry->loadedRamAddr != NULL) {

src/code/z_actor.c

@@ -13,8 +13,10 @@
 #include "sys_matrix.h"
 #include "terminal.h"
 #include "versions.h"
+#include "z_actor_dlftbls.h"
 #include "z_lib.h"
 #include "zelda_arena.h"
+#include "z64actor.h"
 #include "z64effect.h"
 #include "z64light.h"
 #include "z64horse.h"
@@ -32,7 +34,7 @@
 #include "assets/objects/object_bdoor/object_bdoor.h"
 
 #pragma increment_block_number "gc-eu:128 gc-eu-mq:128 gc-jp:128 gc-jp-ce:128 gc-jp-mq:128 gc-us:128 gc-us-mq:128" \
-                               "ntsc-1.0:0 ntsc-1.1:0 ntsc-1.2:0 pal-1.0:0 pal-1.1:0"
+                               "ntsc-1.0:128 ntsc-1.1:0 ntsc-1.2:0 pal-1.0:0 pal-1.1:0"
 
 CollisionPoly* sCurCeilingPoly;
 s32 sCurCeilingBgId;

src/code/z_actor_dlftbls.c

@@ -1,5 +1,8 @@
-#include "global.h"
 #include "fault.h"
+#include "segment_symbols.h"
+#include "z_actor_dlftbls.h"
+
+#include "macros.h"
 
 // Linker symbol declarations (used in the table below)
 #define DEFINE_ACTOR(name, _1, _2, _3) DECLARE_OVERLAY_SEGMENT(name)

src/code/z_bgcheck.c

@@ -11,7 +11,7 @@
 #include "z64player.h"
 #include "z64skin_matrix.h"
 
-#pragma increment_block_number "ntsc-1.0:176 ntsc-1.1:176 ntsc-1.2:176"
+#pragma increment_block_number "ntsc-1.0:184 ntsc-1.1:184 ntsc-1.2:184"
 
 u16 DynaSSNodeList_GetNextNodeIdx(DynaSSNodeList* nodeList);
 void BgCheck_GetStaticLookupIndicesFromPos(CollisionContext* colCtx, Vec3f* pos, Vec3i* sector);

src/code/z_camera.c

@@ -3642,7 +3642,7 @@ s32 Camera_KeepOn3(Camera* camera) {
 }
 
 #pragma increment_block_number "gc-eu:128 gc-eu-mq:128 gc-jp:128 gc-jp-ce:128 gc-jp-mq:128 gc-us:128 gc-us-mq:128" \
-                               "ique-cn:128 ntsc-1.0:109 ntsc-1.1:109 ntsc-1.2:109 pal-1.0:107 pal-1.1:107"
+                               "ique-cn:128 ntsc-1.0:120 ntsc-1.1:120 ntsc-1.2:120 pal-1.0:118 pal-1.1:118"
 
 s32 Camera_KeepOn4(Camera* camera) {
     static Vec3f D_8015BD50;

src/code/z_demo.c

@@ -144,7 +144,7 @@ u16 gCamAtSplinePointsAppliedFrame;
 u16 gCamEyePointAppliedFrame;
 u16 gCamAtPointAppliedFrame;
 
-#pragma increment_block_number "gc-eu:0 gc-eu-mq:0 gc-jp:0 gc-jp-ce:0 gc-jp-mq:0 gc-us:0 gc-us-mq:0 ique-cn:0" \
+#pragma increment_block_number "gc-eu:0 gc-eu-mq:128 gc-jp:0 gc-jp-ce:0 gc-jp-mq:128 gc-us:0 gc-us-mq:128 ique-cn:0" \
                                "ntsc-1.0:128 ntsc-1.1:128 ntsc-1.2:128 pal-1.0:128 pal-1.1:128"
 
 // Cam ID to return to when a scripted cutscene is finished

src/code/z_effect_soft_sprite.c

@@ -1,8 +1,10 @@
 #include "libu64/overlay.h"
-#include "global.h"
+#include "sfx.h"
 #include "terminal.h"
-
+#include "zelda_arena.h"
 #include "z64frame_advance.h"
+#include "z64effect.h"
+#include "z64play.h"
 
 EffectSsInfo sEffectSsInfo = { 0 }; // "EffectSS2Info"
 

src/code/z_en_item00.c

@@ -22,7 +22,7 @@
 #include "assets/objects/gameplay_keep/gameplay_keep.h"
 
 #pragma increment_block_number "gc-eu:128 gc-eu-mq:128 gc-eu-mq-dbg:0 gc-jp:128 gc-jp-ce:128 gc-jp-mq:128 gc-us:128" \
-                               "gc-us-mq:128 ntsc-1.2:128"
+                               "gc-us-mq:128 ntsc-1.0:128 ntsc-1.2:128"
 
 #define FLAGS 0
 

src/code/z_game_dlftbls.c

@@ -1,11 +1,11 @@
-#include "setup_state.h"
-#include "map_select_state.h"
+#include "segment_symbols.h"
 #include "console_logo_state.h"
-#include "z64play.h"
-#include "title_setup_state.h"
 #include "file_select_state.h"
-
-#include "global.h"
+#include "map_select_state.h"
+#include "setup_state.h"
+#include "title_setup_state.h"
+#include "z_game_dlftbls.h"
+#include "z64play.h"
 
 // Linker symbol declarations (used in the table below)
 #define DEFINE_GAMESTATE(typeName, enumName, name) DECLARE_OVERLAY_SEGMENT(name)

src/code/z_kaleido_manager.c

@@ -1,7 +1,11 @@
+#include "libu64/debug.h"
 #include "libu64/overlay.h"
-
-#include "global.h"
+#include "kaleido_manager.h"
+#include "segment_symbols.h"
 #include "terminal.h"
+#include "z64play.h"
+
+#include "macros.h"
 
 #define KALEIDO_OVERLAY(name, nameString) \
     { NULL, ROM_FILE(ovl_##name), _ovl_##name##SegmentStart, _ovl_##name##SegmentEnd, 0, nameString, }

src/code/z_kaleido_scope_call.c

@@ -1,5 +1,5 @@
-#pragma increment_block_number "gc-eu:192 gc-eu-mq:192 gc-jp:192 gc-jp-ce:192 gc-jp-mq:192 gc-us:192 gc-us-mq:192" \
-                               "ique-cn:192 ntsc-1.0:224 ntsc-1.1:224 ntsc-1.2:224 pal-1.0:224 pal-1.1:224"
+#pragma increment_block_number "gc-eu:224 gc-eu-mq:224 gc-jp:224 gc-jp-ce:224 gc-jp-mq:224 gc-us:224 gc-us-mq:224" \
+                               "ique-cn:224 ntsc-1.0:224 ntsc-1.1:224 ntsc-1.2:224 pal-1.0:224 pal-1.1:224"
 
 #include "libu64/debug.h"
 #include "kaleido_manager.h"

src/code/z_message.c

@@ -24,7 +24,7 @@
 #include "assets/textures/parameter_static/parameter_static.h"
 
 #pragma increment_block_number "gc-eu:0 gc-eu-mq:0 gc-jp:128 gc-jp-ce:128 gc-jp-mq:128 gc-us:128 gc-us-mq:128" \
-                               "ntsc-1.0:192 ntsc-1.1:192 ntsc-1.2:192 pal-1.0:128 pal-1.1:128"
+                               "ntsc-1.0:208 ntsc-1.1:208 ntsc-1.2:208 pal-1.0:128 pal-1.1:128"
 
 #if !PLATFORM_IQUE
 #define MSG_BUF_DECODED (msgCtx->msgBufDecoded)

src/code/z_play.c

@@ -23,6 +23,7 @@
 #include "terminal.h"
 #include "title_setup_state.h"
 #include "versions.h"
+#include "z_actor_dlftbls.h"
 #include "zelda_arena.h"
 #include "z64cutscene_flags.h"
 #include "z64debug_display.h"
@@ -35,8 +36,8 @@
 
 #include "global.h"
 
-#pragma increment_block_number "gc-eu:128 gc-eu-mq:128 gc-jp:128 gc-jp-ce:128 gc-jp-mq:128 gc-us:128 gc-us-mq:128" \
-                               "ique-cn:192 ntsc-1.0:144 ntsc-1.1:144 ntsc-1.2:144 pal-1.0:144 pal-1.1:144"
+#pragma increment_block_number "gc-eu:128 gc-eu-mq:128 gc-jp:0 gc-jp-ce:0 gc-jp-mq:0 gc-us:0 gc-us-mq:0 ique-cn:192" \
+                               "ntsc-1.0:144 ntsc-1.1:144 ntsc-1.2:144 pal-1.0:144 pal-1.1:144"
 
 TransitionTile gTransitionTile;
 s32 gTransitionTileState;
@@ -325,7 +326,7 @@ void Play_Init(GameState* thisx) {
     Camera_OverwriteStateFlags(&this->mainCamera, CAM_STATE_CHECK_BG_ALT | CAM_STATE_CHECK_WATER | CAM_STATE_CHECK_BG |
                                                       CAM_STATE_EXTERNAL_FINISHED | CAM_STATE_CAM_FUNC_FINISH |
                                                       CAM_STATE_LOCK_MODE | CAM_STATE_DISTORTION | CAM_STATE_PLAY_INIT);
-    Sram_Init(this, &this->sramCtx);
+    Sram_Init(&this->state, &this->sramCtx);
     Regs_InitData(this);
     Message_Init(this);
     GameOver_Init(this);

src/code/z_prenmi.c

@@ -1,9 +1,13 @@
+#include "gfx.h"
+#include "gfx_setupdl.h"
 #include "prenmi_state.h"
-
-#include "global.h"
+#include "regs.h"
 #include "terminal.h"
 #include "versions.h"
 
+#include "macros.h"
+#include "global.h"
+
 void func_80092320(PreNMIState* this) {
     this->state.running = false;
     this->state.init = NULL;

src/code/z_sample.c

@@ -1,6 +1,11 @@
+#include "gfx.h"
+#include "gfx_setupdl.h"
+#include "controller.h"
+#include "regs.h"
 #include "sample_state.h"
-
-#include "global.h"
+#include "segment_symbols.h"
+#include "z64dma.h"
+#include "z64play.h"
 
 void Sample_HandleStateChange(SampleState* this) {
     if (CHECK_BTN_ALL(this->state.input[0].press.button, BTN_START)) {

src/code/z_scene.c

@@ -2,6 +2,7 @@
 #include "seqcmd.h"
 #include "terminal.h"
 #include "versions.h"
+#include "z_actor_dlftbls.h"
 #include "z64save.h"
 
 SceneCmdHandlerFunc sSceneCmdHandlers[SCENE_CMD_ID_MAX];

src/code/z_sram.c

@@ -1,10 +1,16 @@
 #include "file_select_state.h"
-#include "global.h"
+#include "controller.h"
 #include "terminal.h"
 #include "versions.h"
+#include "z64game.h"
+#include "z64message.h"
 #include "z64save.h"
+#include "z64scene.h"
+#include "z64sram.h"
 #include "z64ss_sram.h"
 
+#include "global.h"
+
 #define SLOT_SIZE (sizeof(SaveContext) + 0x28)
 #define CHECKSUM_SIZE (sizeof(Save) / 2)
 
@@ -1060,5 +1066,5 @@ void Sram_Alloc(GameState* gameState, SramContext* sramCtx) {
     ASSERT(sramCtx->readBuff != NULL, "sram->read_buff != NULL", "../z_sram.c", 1295);
 }
 
-void Sram_Init(PlayState* play, SramContext* sramCtx) {
+void Sram_Init(GameState* gameState, SramContext* sramCtx) {
 }