From 3f4e4f25d4ce422c0109397ccfdf8b30371fa09c Mon Sep 17 00:00:00 2001 From: fig02 Date: Fri, 30 Dec 2022 07:47:54 -0500 Subject: [PATCH] document bug in eff_ss_d_fire (#1481) --- src/overlays/effects/ovl_Effect_Ss_D_Fire/z_eff_ss_d_fire.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/overlays/effects/ovl_Effect_Ss_D_Fire/z_eff_ss_d_fire.c b/src/overlays/effects/ovl_Effect_Ss_D_Fire/z_eff_ss_d_fire.c index 8d949c9e5b..5ca2c08afc 100644 --- a/src/overlays/effects/ovl_Effect_Ss_D_Fire/z_eff_ss_d_fire.c +++ b/src/overlays/effects/ovl_Effect_Ss_D_Fire/z_eff_ss_d_fire.c @@ -35,7 +35,12 @@ u32 EffectSsDFire_Init(PlayState* play, u32 index, EffectSs* this, void* initPar this->pos = initParams->pos; this->velocity = initParams->velocity; this->accel = initParams->accel; + + //! @bug Segment 6 is not set to the required object before setting this display list. + //! It works out in practice because this effect is spawned from an actor who uses the same object + //! and previously already set it to segment 6. this->gfx = SEGMENTED_TO_VIRTUAL(gDodongoFireDL); + this->life = initParams->life; this->rScale = initParams->scale; this->rScaleStep = initParams->scaleStep;