mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-02-24 00:25:48 +00:00
Code Issues Projects Releases Wiki Activity

investigated significance of garbage cursor position in magic arrows equips (result: none)

Browse source
This commit is contained in:
Dragorn421 2023-11-04 22:31:28 +01:00
parent 4f312782c5
commit 4b1f978ce6
No known key found for this signature in database
GPG key ID: 381AEBAF3D429335
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/overlays/misc/ovl_kaleido_scope/z_kaleido_item.c
View file

@ -468,6 +468,9 @@ void KaleidoScope_DrawItemSelect(PlayState* play) {
&gSfxDefaultFreqAndVolScale, &gSfxDefaultReverb);
}
} else if ((pauseCtx->mainState == PAUSE_MAIN_STATE_3) && (pauseCtx->pageIndex == PAUSE_ITEM)) {
//! @bug cursorSlot is used uninitialized
// This leads to reading from the itemVtx array at some index, typically OOB, and setting the cursor to an
// unexpected position. However the cursor is not drawn in this state so it ends up not being an issue.
KaleidoScope_SetCursorPos(pauseCtx, cursorSlot * 4, pauseCtx->itemVtx);
pauseCtx->cursorColorSet = 4;
}