1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-08-21 06:21:16 +00:00

Fix misc 21 (#1573)

* Make `sNew` in (unused) `code_800FC620.c` a string

It is passed as a filename to `__osMallocDebug` so should be a nul-terminated string, not a char[3] missing an explicit \0

* Fix gcc warning in `JpegDecoder_ParseNextSymbol` about SLL on negative value

-1U is an unsigned value, aka 0xFFFFFFFF
I keep -1 because it seems that's what a jpeg standard has too

References:
https://stackoverflow.com/questions/40508958/shifting-a-negative-signed-value-is-undefined
https://www.w3.org/Graphics/JPEG/itu-t81.pdf (page 105, figure F.12)

* Small cleanup

* Fix few mistakes (thanks gcc warnings)

* Add `@bug` in file select settings draw code, using the wrong array

* format

* format main

* rename arg for a happy formatter

* Move important function call out of a printf
This commit is contained in:
Dragorn421 2023-11-12 22:59:52 +01:00 committed by GitHub
parent dc323052c3
commit 4c75260097
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 47 additions and 39 deletions

View file

@ -776,19 +776,19 @@ void EnFr_CheckOcarinaInputFrogSong(u8 ocarinaNote) {
s32 frogIndex;
switch (ocarinaNote) {
case 0:
case OCARINA_BTN_A:
frogIndexButterfly = FROG_BLUE;
break;
case 1:
case OCARINA_BTN_C_DOWN:
frogIndexButterfly = FROG_YELLOW;
break;
case 2:
case OCARINA_BTN_C_RIGHT:
frogIndexButterfly = FROG_RED;
break;
case 3:
case OCARINA_BTN_C_LEFT:
frogIndexButterfly = FROG_PURPLE;
break;
case 4:
case OCARINA_BTN_C_UP:
frogIndexButterfly = FROG_WHITE;
}
// Turn on or off butterfly above frog