mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-02-04 19:24:28 +00:00
Code Issues Projects Releases Wiki Activity

fix_bss.py: Gracefully handle EGCS-compiled files (#2452)

Browse source
This commit is contained in:
cadmic 2025-02-02 22:42:31 -08:00 • committed by GitHub
parent ef53bfd693
commit 6c06168e72
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
tools/fix_bss.py
View file

@ -91,6 +91,11 @@ def read_relocs(object_path: Path, section_name: str) -> list[Reloc]:
with open(object_path, "rb") as f: with open(object_path, "rb") as f:
elffile = elftools.elf.elffile.ELFFile(f) elffile = elftools.elf.elffile.ELFFile(f)
symtab = elffile.get_section_by_name(".symtab") symtab = elffile.get_section_by_name(".symtab")
section = elffile.get_section_by_name(section_name)
if section is None:
return []
data = elffile.get_section_by_name(section_name).data() data = elffile.get_section_by_name(section_name).data()
reloc_section = elffile.get_section_by_name(f".rel{section_name}") reloc_section = elffile.get_section_by_name(f".rel{section_name}")
@ -698,6 +703,12 @@ def process_file(
raise FixBssException(f"Could not determine compiler command line for {file}") raise FixBssException(f"Could not determine compiler command line for {file}")
output(f"Compiler command: {shlex.join(command_line)}") output(f"Compiler command: {shlex.join(command_line)}")
if any(s.startswith("tools/egcs/") for s in command_line):
raise FixBssException(
"Can't automatically fix BSS ordering for EGCS-compiled files"
)
symbol_table, ucode = run_cfe(command_line, keep_files=False) symbol_table, ucode = run_cfe(command_line, keep_files=False)
bss_variables = find_bss_variables(symbol_table, ucode) bss_variables = find_bss_variables(symbol_table, ucode)