mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-06-08 09:31:52 +00:00
Code Issues Projects Releases Wiki Activity

fixes

Browse source
This commit is contained in:
mzxrules 2025-06-06 20:54:51 -04:00
parent 8cbdc701dc
commit 74a415a643
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/code/graph.c
View file

@ -143,9 +143,10 @@ void Graph_InitTHGA(GraphicsContext* gfxCtx) {
//! @bug fbIdx is a signed integer that can overflow into the negatives. When compiled with a C99+ compiler or IDO, //! @bug fbIdx is a signed integer that can overflow into the negatives. When compiled with a C99+ compiler or IDO,
//! the remainder operator will yield -1 for odd negative values of fbIdx. //! the remainder operator will yield -1 for odd negative values of fbIdx.
//! This results in an out of bounds array access in SysCfb_GetFbPtr due to the negative index value. //! This results in an out of bounds array access in SysCfb_GetFbPtr due to the negative index value,
//! which will crash the game.
//! //!
//! In practice, this isn't issue. In the worst case scenario with the game operating at a consistent 60 FPS, //! In practice, this isn't an issue. In the worst case scenario with the game operating at a consistent 60 FPS,
//! it would take approximately 414.25 days of continuous operation for fbIdx to overflow. //! it would take approximately 414.25 days of continuous operation for fbIdx to overflow.
gfxCtx->curFrameBuffer = SysCfb_GetFbPtr(gfxCtx->fbIdx % 2); gfxCtx->curFrameBuffer = SysCfb_GetFbPtr(gfxCtx->fbIdx % 2);
gfxCtx->unk_014 = 0; gfxCtx->unk_014 = 0;