mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2024-12-25 22:26:12 +00:00
Code Issues Projects Releases Wiki Activity

AVOID_UB for out-of-bounds access in AudioLoad_Init (#1902)

Browse source
This commit is contained in:
Tharo 2024-02-28 14:06:03 +00:00 committed by GitHub
parent c521f1f8ae
commit 7a2c46d4eb
No account linked to committer's email address
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/audio/lib/load.c
View file

@ -1133,9 +1133,19 @@ void AudioLoad_Init(void* heap, u32 heapSize) {
s32 i;
u8* audioContextPtr = (u8*)&gAudioCtx;
#ifndef AVOID_UB
//! @bug This clearing loop sets one extra byte to 0 following gAudioCtx.
//! In practice this is harmless as it would set the most significant byte in gAudioCustomUpdateFunction to 0,
//! which was just reset to NULL above.
for (i = sizeof(gAudioCtx); i >= 0; i--) {
*audioContextPtr++ = 0;
}
#else
// Avoid out-of-bounds variable access
for (i = sizeof(gAudioCtx); i > 0; i--) {
*audioContextPtr++ = 0;
}
#endif
}
// 1000 is a conversion from seconds to milliseconds