mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-06-08 01:21:52 +00:00
Code Issues Projects Releases Wiki Activity

cleaner comment

Browse source
This commit is contained in:
mzxrules 2025-06-05 16:04:13 -04:00
parent 922389fd6b
commit 8cbdc701dc
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/code/graph.c
View file

@ -141,9 +141,12 @@ void Graph_InitTHGA(GraphicsContext* gfxCtx) {
gfxCtx->overlayBuffer = pool->overlayBuffer;
gfxCtx->workBuffer = pool->workBuffer;
//! @bug fbIdx is a signed integer that can overflow into the negatives. When compiled with IDO, the remainder
//! operator will yield -1 for odd negative values of fbIdx (i.e. the same as C99 onwards).
//! @bug fbIdx is a signed integer that can overflow into the negatives. When compiled with a C99+ compiler or IDO,
//! the remainder operator will yield -1 for odd negative values of fbIdx.
//! This results in an out of bounds array access in SysCfb_GetFbPtr due to the negative index value.
//!
//! In practice, this isn't issue. In the worst case scenario with the game operating at a consistent 60 FPS,
//! it would take approximately 414.25 days of continuous operation for fbIdx to overflow.
gfxCtx->curFrameBuffer = SysCfb_GetFbPtr(gfxCtx->fbIdx % 2);
gfxCtx->unk_014 = 0;
}