mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2024-09-21 12:54:51 +00:00
Code Issues Projects Releases Wiki Activity

MacOS ZAPD fixes (#606)

Browse Source 
* Adding -Wno-return-type to GCC check for MacOS

* git subrepo pull --force tools/ZAPD

subrepo:
  subdir:   "tools/ZAPD"
  merged:   "0325ec161"
upstream:
  origin:   "https://github.com/zeldaret/ZAPD.git"
  branch:   "master"
  commit:   "0325ec161"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo.git"
  commit:   "2f68596"

* git subrepo pull --force tools/ZAPD

subrepo:
  subdir:   "tools/ZAPD"
  merged:   "605f6972e"
upstream:
  origin:   "https://github.com/zeldaret/ZAPD.git"
  branch:   "master"
  commit:   "605f6972e"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo.git"
  commit:   "2f68596"

* git subrepo pull --force tools/ZAPD

subrepo:
  subdir:   "tools/ZAPD"
  merged:   "6e6ad445a"
upstream:
  origin:   "https://github.com/zeldaret/ZAPD.git"
  branch:   "master"
  commit:   "6e6ad445a"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo.git"
  commit:   "2f68596"

* Rewrote func to avoid returns without values
This commit is contained in:
Ethan Roseman 2021-01-10 04:04:36 -05:00 committed by GitHub
parent 115c152b03
commit bda5b83346
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 38 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
extract_assets.py Normal file → Executable file
View File

24
src/code/z_camera.c
View File

@ -7160,26 +7160,24 @@ s32 Camera_CheckWater(Camera* camera) {
if (camera->unk_150 > 0) { if (camera->unk_150 > 0) {
camera->unk_150--; camera->unk_150--;
camera->unk_152 |= 8; camera->unk_152 |= 8;
return;
} else if (camera->globalCtx->sceneNum == 0x49) { } else if (camera->globalCtx->sceneNum == 0x49) {
camera->unk_152 |= 0x10; camera->unk_152 |= 0x10;
return;
} else { } else {
camera->unk_152 |= 2; camera->unk_152 |= 2;
return;
} }
} } else {
if (camera->unk_14C & 0x100) { if (camera->unk_14C & 0x100) {
camera->unk_14C &= ~0x100; camera->unk_14C &= ~0x100;
osSyncPrintf("kankyo changed water off, sound off\n"); osSyncPrintf("kankyo changed water off, sound off\n");
func_800706A0(camera->globalCtx); func_800706A0(camera->globalCtx);
if (*quakeId != 0) { if (*quakeId != 0) {
Quake_RemoveFromIdx(*quakeId); Quake_RemoveFromIdx(*quakeId);
}
camera->unk_150 = 0;
camera->unk_152 = 0;
} }
camera->unk_150 = 0; func_800F6828(0);
camera->unk_152 = 0;
} }
func_800F6828(0);
// @BUG: doesn't always return a value, but sometimes does. // @BUG: doesn't always return a value, but sometimes does.
} }

4
tools/ZAPD/.gitrepo
View File

@ -6,7 +6,7 @@
[subrepo] [subrepo]
remote = https://github.com/zeldaret/ZAPD.git remote = https://github.com/zeldaret/ZAPD.git
branch = master branch = master
commit = fd4d53a2684871a1ac28668515d025470a45ef7f commit = 6e6ad445a69089b721bea75f6e43b23b14a553b6
parent = cbe216b1810f9274242d0088a7e3b15b0f95f55d parent = cf6d96f133d98c6b69066c5ff195dc8a4d029444
method = merge method = merge
cmdver = 0.4.3 cmdver = 0.4.3

22
tools/ZAPD/ZAPD/ZRoom/Commands/SetPathways.cpp
View File

@ -59,6 +59,15 @@ string SetPathways::GenerateSourceCodePass1(string roomName, int baseAddress)
currentPtr += 6; currentPtr += 6;
} }
if (numPoints == 0) // Hack for SharpOcarina
{
for (int i = 0; i < 3; i++)
{
PathwayEntry* entry = new PathwayEntry();
pathways.push_back(entry);
}
}
return ""; return "";
} }
@ -82,7 +91,11 @@ string SetPathways::GenerateSourceCodePass2(string roomName, int baseAddress)
int index = 0; int index = 0;
for (PathwayEntry* entry : pathways) for (PathwayEntry* entry : pathways)
{ {
declaration += StringHelper::Sprintf("{ %i, %i, %i }, //0x%06X \n", entry->x, entry->y, entry->z, listSegmentOffset + (index * 6)); declaration += StringHelper::Sprintf(" { %i, %i, %i }, //0x%06X", entry->x, entry->y, entry->z, listSegmentOffset + (index * 6));
if (index < pathways.size() - 1)
declaration += "\n";
index++; index++;
} }
@ -112,3 +125,10 @@ RoomCommand SetPathways::GetRoomCommand()
{ {
return RoomCommand::SetPathways; return RoomCommand::SetPathways;
} }
PathwayEntry::PathwayEntry()
{
x = 0;
y = 0;
z = 0;
}

2
tools/ZAPD/ZAPD/ZRoom/Commands/SetPathways.h
View File

@ -7,6 +7,8 @@ class PathwayEntry
{ {
public: public:
int16_t x, y, z; int16_t x, y, z;
PathwayEntry();
}; };
class SetPathways : public ZRoomCommand class SetPathways : public ZRoomCommand

2
tools/ZAPD/ZAPD/ZVector.cpp
View File

@ -80,7 +80,7 @@ std::string ZVector::GetSourceTypeName()
} }
else else
{ {
std::string output = StringHelper::Sprintf("Encountered unsupported vector type: %d dimensions, %s type", dimensions, ZScalar::MapScalarTypeToOutputType(scalarType)); std::string output = StringHelper::Sprintf("Encountered unsupported vector type: %d dimensions, %s type", dimensions, ZScalar::MapScalarTypeToOutputType(scalarType).c_str());
if (Globals::Instance->verbosity >= VERBOSITY_DEBUG) if (Globals::Instance->verbosity >= VERBOSITY_DEBUG)
printf("%s\n", output.c_str()); printf("%s\n", output.c_str());