From dc010abf7a3173a18289161aa275204e38b262fb Mon Sep 17 00:00:00 2001 From: Derek Hensley Date: Fri, 22 Sep 2023 08:40:19 -0700 Subject: [PATCH] Rename master to main (#1536) * Jenkinsfile master -> main * Missed some instances of master --- Jenkinsfile | 8 ++++---- README.md | 4 ++-- docs/tutorial/merging.md | 8 ++++---- docs/tutorial/pre-decomp.md | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Jenkinsfile b/Jenkinsfile index b4c23f20a0..0d2d74fbc4 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -17,7 +17,7 @@ pipeline { } stage('Build (qemu-irix)') { when { - branch 'master' + branch 'main' } steps { sh 'ORIG_COMPILER=1 make -j' @@ -26,7 +26,7 @@ pipeline { stage('Build') { when { not { - branch 'master' + branch 'main' } } steps { @@ -35,7 +35,7 @@ pipeline { } stage('Report Progress') { when { - branch 'master' + branch 'main' } steps { sh 'mkdir reports' @@ -47,7 +47,7 @@ pipeline { } stage('Update Progress') { when { - branch 'master' + branch 'main' } agent { label 'zeldaret_website' diff --git a/README.md b/README.md index c034dac25a..6fe29f6b8a 100644 --- a/README.md +++ b/README.md @@ -2,8 +2,8 @@ [![Build Status][jenkins-badge]][jenkins] [![Decompilation Progress][progress-badge]][progress] [![Contributors][contributors-badge]][contributors] [![Discord Channel][discord-badge]][discord] -[jenkins]: https://jenkins.deco.mp/job/OOT/job/master -[jenkins-badge]: https://img.shields.io/jenkins/build?jobUrl=https%3A%2F%2Fjenkins.deco.mp%2Fjob%2FOOT%2Fjob%2Fmaster +[jenkins]: https://jenkins.deco.mp/job/OOT/job/main +[jenkins-badge]: https://img.shields.io/jenkins/build?jobUrl=https%3A%2F%2Fjenkins.deco.mp%2Fjob%2FOOT%2Fjob%2Fmain [progress]: https://zelda64.dev/games/oot [progress-badge]: https://img.shields.io/endpoint?url=https://zelda64.dev/assets/csv/progress-oot-shield.json diff --git a/docs/tutorial/merging.md b/docs/tutorial/merging.md index a5e7b66f69..8ba1aa5cb3 100644 --- a/docs/tutorial/merging.md +++ b/docs/tutorial/merging.md @@ -61,9 +61,9 @@ If you can't match a function even with everyone's, don't worry overlong about i Run the formatting script `format.py`, to format the C files in the standard way we use. -### Merge master +### Merge main -To make sure the PR builds correctly with the current master, you need to merge `upstream/master` before you make the PR. This tends to break things, that you have to fix to get it to compile correctly again. +To make sure the PR builds correctly with the current main, you need to merge `upstream/main` before you make the PR. This tends to break things, that you have to fix to get it to compile correctly again. ## Pull Requests @@ -81,7 +81,7 @@ and so on, although these four tend to cover most cases. Feel free to add a comm Pull requests may be reviewed by anyone (who knows enough about the conventions of the project), but all are usually reviewed by Fig and Roman. -To implement suggestions made in reviews, it is generally easier to be consistent if you push more commits from your local branch. It is quite possible that in the meantime some other PR has gone in, and git will ask you to merge master before you add more commits. This is normally fairly painless, although often you have to resolve merge conflicts. If in doubt, backup your work before doing anything, and ask in Discord before doing anything drastic, or if you don't understand what git is telling you. +To implement suggestions made in reviews, it is generally easier to be consistent if you push more commits from your local branch. It is quite possible that in the meantime some other PR has gone in, and git will ask you to merge main before you add more commits. This is normally fairly painless, although often you have to resolve merge conflicts. If in doubt, backup your work before doing anything, and ask in Discord before doing anything drastic, or if you don't understand what git is telling you. There is no need to wait for your PR to be approved and committed before working on your next actor. @@ -94,4 +94,4 @@ It's helpful to use the labels on Trello. - Matched for when it is totally decompiled and matching - Documented if at least everything is named and odd code is commented. We'll likely wipe these and start over when proper documentation begins. -We now have a PR label on the Trello that you can use to indicate your actor is in a PR. When the actor is committed to master, you can move the actor into the `Decompiled Files (Overlays)` column: it goes at the top if there is a non-matching, and below if not. +We now have a PR label on the Trello that you can use to indicate your actor is in a PR. When the actor is committed to main, you can move the actor into the `Decompiled Files (Overlays)` column: it goes at the top if there is a non-matching, and below if not. diff --git a/docs/tutorial/pre-decomp.md b/docs/tutorial/pre-decomp.md index ebd722fbd8..4ad66b76f5 100644 --- a/docs/tutorial/pre-decomp.md +++ b/docs/tutorial/pre-decomp.md @@ -10,7 +10,7 @@ This is covered on the main page of the repository. First, make a GitHub fork of the repository, then clone it into a git-enabled local folder. -Once you have decided on an actor, you should make a new git branch to work on: your master branch is meant to stay level with the main repository. Name it something sensible: my `EnFirefly` branch is called "en_firefly", for example, but you may prefer to use a more descriptive name: "Dark_Link" is rather more suggestive than "en_torch2", for example. You work on the branch, commit changes, and periodically push them to GitHub, if only for backup purposes. +Once you have decided on an actor, you should make a new git branch to work on: your main branch is meant to stay level with the main repository. Name it something sensible: my `EnFirefly` branch is called "en_firefly", for example, but you may prefer to use a more descriptive name: "Dark_Link" is rather more suggestive than "en_torch2", for example. You work on the branch, commit changes, and periodically push them to GitHub, if only for backup purposes. Once you have finished an actor, you submit a pull request for other people to check your work complies with the project's conventions, and once it is deemed satisfactory, it will be merged in to the main repository.