mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-07-13 11:24:40 +00:00
Code Issues Projects Releases Wiki Activity

Enable more IDO warnings and apply fixes (#1264)

Browse source 
* Update asm-processor and fix includes with EARLY

* Enable more IDO warnings and disable unwanted warning 516

* Fix most new and remaining warnings

* Improve skelanime comment

* Improve asmproc pragma comment

Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>

* Add suggested comment for a wrong prototype

* Update asm-processor with the latest fix

Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
This commit is contained in:
Roman971 2022-06-13 01:24:45 +02:00 • committed by GitHub
parent 4cb1c3345f
commit feadb0d9ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 269 additions and 148 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/code/code_800F9280.c
View file

@ -96,9 +96,10 @@ typedef enum {
} SeqCmdType;
void Audio_ProcessSeqCmd(u32 cmd) {
s32 pad[2];
s32 pad;
u16 fadeTimer;
u16 channelMask;
u32 channelMaskReversed;
u16 val;
u8 oldSpec;
u8 spec;
@ -305,9 +306,10 @@ void Audio_ProcessSeqCmd(u32 cmd) {
// stop channels
Audio_QueueCmdS8(0x08000000 | _SHIFTL(playerIdx, 16, 8) | 0xFF00, 1);
}
if ((channelMask ^ 0xFFFF) != 0) {
channelMaskReversed = channelMask ^ 0xFFFF;
if (channelMaskReversed != 0) {
// with channel mask ~channelMask...
Audio_QueueCmdU16(0x90000000 | _SHIFTL(playerIdx, 16, 8), (channelMask ^ 0xFFFF));
Audio_QueueCmdU16(0x90000000 | _SHIFTL(playerIdx, 16, 8), channelMaskReversed);
// unstop channels
Audio_QueueCmdS8(0x08000000 | _SHIFTL(playerIdx, 16, 8) | 0xFF00, 0);
}