1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2025-01-15 21:07:15 +00:00
oot/asm
Kenix3 f4499a8de2
En_Clear_Tag OK and documented (#689)
* Decompile and document En_Clear_Tag

* Adds a define for setting the total count of ClearTag particles.

* Fixes swap in particle effect struct member names.

Additionally, implements the DECR macro where available.
Additionally, implements the CLAMP_MIN macro.
Additionally, adds more comments inside of functions explaining how the Arwing works.

* Reformats z_en_clear_tag.c after recent fixes.

* Removes not OK DECR and CLAMP_MIN macros.

I don't know why they built locally OK for me. May have had a stale build.

* Added static to data declarations.

Additionally added white spacing between data definitions.

* Various syling fixes in EnClearTag

Fixes inconsistent usage of particle/effect. They're Effect is the better name, so I went with that.

Fixed a naming issue in CalculateFloorTangent.

Adds s prefix to all the static variables.

Renames clearTagParticlesBuffer to sClearTagEffects

Consistent capitalization in comments.

Adds more descriptive comments to function level comments that didn't say a lot already.

Renamed gameplay.particleEffects to gameplay.specialEffects.

Renames cameraNumber to cameraId.

Fixed capitalization in display list variable names.

* Always capitalize the A in arwing.

* Fixes issue with overzealous replacement of arwing -> Arwing

* Renames arwing display lists to include the g prefix.

* Renames effect seed -> random

* Removes unnecessary decrement timer comments.

* Updates Arwing comments to detail why it's important that the roll is updated to zero.

* Updates stack variable names in EnClearTag_Update to be more consistent with each other.

* Updates Arwing crashing documentation.

* Further update documentation on arwing crashing.

* Even further updates to Arwing crashing docs.

* Fixes issue of missing newline in En_Clear_Tag.xml

* targetDirection reset now has a chained assignment

* Rotation angle to hex

* Fixes rotation hex and identifies float.

* Updates arwing fire check.

* Arwing cutscene timer is multiplied by 128 rather than shifting 7

* Updates scaledCrashingTimer assignment to be more consistent.

* Updates max scale to multiply by 2

* Gives name to the work buffer indices.

Additionally, makes enum names more consistent.

* Removes unnecessary globalCtx2 in EnClearTag_CreateFlashEffect

* Runs format.sh after recent changes.

* Updated path of ClearTag assets.

* Clear tag now uses Arwing in the display list name for all effects.

* Updates work buffer to expand and contract as new enums are added.

* Uses c99 defines in my c89

* Updates the unknown 8 bytes in en_clear_tag

* review

Co-authored-by: fig02 <fig02srl@gmail.com>
2021-03-29 19:14:08 +02:00
..
non_matchings En_Clear_Tag OK and documented (#689) 2021-03-29 19:14:08 +02:00
overlays/data/ovl_map_mark_data Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osDisableInt.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osGetCause.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osGetFpcCsr.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osGetSR.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osProbeTLB.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osRestoreInt.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osSetCompare.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osSetFpcCsr.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osSetSR.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
__osSetWatchLo.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
bcmp.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
bcopy.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
bzero.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
code_800D71F0.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
dmadata.s First proper commit. 2020-03-17 00:31:30 -04:00
entry.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
exceptasm.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
fp.s code_800FCE80 OK 2020-03-21 03:43:48 +01:00
guMtxF2L.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
guMtxIdent.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
guMtxIdentF.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
guMtxL2F.s Decompile the last of libultra_code_O2 (#464) 2020-10-28 15:59:18 -04:00
guNormalize.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
guScale.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
guTranslate.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
ipl3.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
mio0.s ucode_disas.c progress (#188) 2020-06-05 13:18:39 -04:00
osGetCount.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
osInvalDCache.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
osInvalICache.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
osMapTLBRdb.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
osSetIntMask.s Update asm processor and migrate/improve rodata for a few files (#209) 2020-06-14 19:24:09 -04:00
osUnmapTLBAll.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
osWritebackDCache.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
osWritebackDCacheAll.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
rom_header.s Disassemble the rom header and entrypoint function (#87) 2020-04-22 13:44:46 -04:00