1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2024-11-25 09:45:02 +00:00
oot/data
Kenix3 f4499a8de2
En_Clear_Tag OK and documented (#689)
* Decompile and document En_Clear_Tag

* Adds a define for setting the total count of ClearTag particles.

* Fixes swap in particle effect struct member names.

Additionally, implements the DECR macro where available.
Additionally, implements the CLAMP_MIN macro.
Additionally, adds more comments inside of functions explaining how the Arwing works.

* Reformats z_en_clear_tag.c after recent fixes.

* Removes not OK DECR and CLAMP_MIN macros.

I don't know why they built locally OK for me. May have had a stale build.

* Added static to data declarations.

Additionally added white spacing between data definitions.

* Various syling fixes in EnClearTag

Fixes inconsistent usage of particle/effect. They're Effect is the better name, so I went with that.

Fixed a naming issue in CalculateFloorTangent.

Adds s prefix to all the static variables.

Renames clearTagParticlesBuffer to sClearTagEffects

Consistent capitalization in comments.

Adds more descriptive comments to function level comments that didn't say a lot already.

Renamed gameplay.particleEffects to gameplay.specialEffects.

Renames cameraNumber to cameraId.

Fixed capitalization in display list variable names.

* Always capitalize the A in arwing.

* Fixes issue with overzealous replacement of arwing -> Arwing

* Renames arwing display lists to include the g prefix.

* Renames effect seed -> random

* Removes unnecessary decrement timer comments.

* Updates Arwing comments to detail why it's important that the roll is updated to zero.

* Updates stack variable names in EnClearTag_Update to be more consistent with each other.

* Updates Arwing crashing documentation.

* Further update documentation on arwing crashing.

* Even further updates to Arwing crashing docs.

* Fixes issue of missing newline in En_Clear_Tag.xml

* targetDirection reset now has a chained assignment

* Rotation angle to hex

* Fixes rotation hex and identifies float.

* Updates arwing fire check.

* Arwing cutscene timer is multiplied by 128 rather than shifting 7

* Updates scaledCrashingTimer assignment to be more consistent.

* Updates max scale to multiply by 2

* Gives name to the work buffer indices.

Additionally, makes enum names more consistent.

* Removes unnecessary globalCtx2 in EnClearTag_CreateFlashEffect

* Runs format.sh after recent changes.

* Updated path of ClearTag assets.

* Clear tag now uses Arwing in the display list name for all effects.

* Updates work buffer to expand and contract as new enums are added.

* Uses c99 defines in my c89

* Updates the unknown 8 bytes in en_clear_tag

* review

Co-authored-by: fig02 <fig02srl@gmail.com>
2021-03-29 19:14:08 +02:00
..
overlays En_Clear_Tag OK and documented (#689) 2021-03-29 19:14:08 +02:00
__libm_qnan_f.rodata.s Matched most remaining libultra files (#221) 2020-07-06 20:15:01 -04:00
audio_effects.data.s audio_playback, audio_effects OK (#313) 2020-08-15 14:06:26 -04:00
code_800D2E30.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
code_800DACC0.bss.s audio_seqplayer, the easy half (#369) 2020-09-01 17:23:30 -04:00
code_800DACC0.data.s audio_seqplayer, the easy half (#369) 2020-09-01 17:23:30 -04:00
code_800E11F0.data.s Remove hard-coded pointers in several files (#186) 2020-06-04 17:51:14 -04:00
code_800E11F0.rodata.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
code_800EC960.data.s En_Fr Frogs 47 of 48 func decomped (#576) 2021-02-02 15:17:51 -05:00
code_800F9280.data.s audio_heap: 1 non-matching (#381) 2020-09-20 13:22:09 -04:00
code_800F9280.rodata.s audio_heap: 1 non-matching (#381) 2020-09-20 13:22:09 -04:00
db_camera.bss.s decompile z_camera (#398) 2020-12-06 17:39:47 -05:00
db_camera.data.s Decompile shrink_window.c (#232) 2020-07-08 21:54:39 -04:00
fault.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
fault_drawer.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
rsp.rodata.s Fix more raw pointers (rsp and part of .data) (#170) 2020-05-27 09:06:37 -04:00
rsp.text.s Fix more raw pointers (rsp and part of .data) (#170) 2020-05-27 09:06:37 -04:00
rsp_boot.text.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_item00.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_item00.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_kankyo.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_kankyo.data.s Fix remaining rom/ram pointers (#190) 2020-06-05 17:09:43 -04:00
z_message_PAL.bss.s Fix remaining rom/ram pointers (#190) 2020-06-05 17:09:43 -04:00
z_message_PAL.rodata.s Update asm processor and migrate/improve rodata for a few files (#209) 2020-06-14 19:24:09 -04:00
z_onepointdemo.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_text.data.s z_select decompiled, 1 non matching left (#202) 2020-06-13 22:59:58 -04:00
z_vr_box.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00