mirror of
https://github.com/zeldaret/oot.git
synced 2024-11-10 19:20:13 +00:00
Rename master to main (#1536)
* Jenkinsfile master -> main * Missed some instances of master
This commit is contained in:
parent
d7f6961918
commit
dc010abf7a
4 changed files with 11 additions and 11 deletions
8
Jenkinsfile
vendored
8
Jenkinsfile
vendored
|
@ -17,7 +17,7 @@ pipeline {
|
||||||
}
|
}
|
||||||
stage('Build (qemu-irix)') {
|
stage('Build (qemu-irix)') {
|
||||||
when {
|
when {
|
||||||
branch 'master'
|
branch 'main'
|
||||||
}
|
}
|
||||||
steps {
|
steps {
|
||||||
sh 'ORIG_COMPILER=1 make -j'
|
sh 'ORIG_COMPILER=1 make -j'
|
||||||
|
@ -26,7 +26,7 @@ pipeline {
|
||||||
stage('Build') {
|
stage('Build') {
|
||||||
when {
|
when {
|
||||||
not {
|
not {
|
||||||
branch 'master'
|
branch 'main'
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
steps {
|
steps {
|
||||||
|
@ -35,7 +35,7 @@ pipeline {
|
||||||
}
|
}
|
||||||
stage('Report Progress') {
|
stage('Report Progress') {
|
||||||
when {
|
when {
|
||||||
branch 'master'
|
branch 'main'
|
||||||
}
|
}
|
||||||
steps {
|
steps {
|
||||||
sh 'mkdir reports'
|
sh 'mkdir reports'
|
||||||
|
@ -47,7 +47,7 @@ pipeline {
|
||||||
}
|
}
|
||||||
stage('Update Progress') {
|
stage('Update Progress') {
|
||||||
when {
|
when {
|
||||||
branch 'master'
|
branch 'main'
|
||||||
}
|
}
|
||||||
agent {
|
agent {
|
||||||
label 'zeldaret_website'
|
label 'zeldaret_website'
|
||||||
|
|
|
@ -2,8 +2,8 @@
|
||||||
|
|
||||||
[![Build Status][jenkins-badge]][jenkins] [![Decompilation Progress][progress-badge]][progress] [![Contributors][contributors-badge]][contributors] [![Discord Channel][discord-badge]][discord]
|
[![Build Status][jenkins-badge]][jenkins] [![Decompilation Progress][progress-badge]][progress] [![Contributors][contributors-badge]][contributors] [![Discord Channel][discord-badge]][discord]
|
||||||
|
|
||||||
[jenkins]: https://jenkins.deco.mp/job/OOT/job/master
|
[jenkins]: https://jenkins.deco.mp/job/OOT/job/main
|
||||||
[jenkins-badge]: https://img.shields.io/jenkins/build?jobUrl=https%3A%2F%2Fjenkins.deco.mp%2Fjob%2FOOT%2Fjob%2Fmaster
|
[jenkins-badge]: https://img.shields.io/jenkins/build?jobUrl=https%3A%2F%2Fjenkins.deco.mp%2Fjob%2FOOT%2Fjob%2Fmain
|
||||||
|
|
||||||
[progress]: https://zelda64.dev/games/oot
|
[progress]: https://zelda64.dev/games/oot
|
||||||
[progress-badge]: https://img.shields.io/endpoint?url=https://zelda64.dev/assets/csv/progress-oot-shield.json
|
[progress-badge]: https://img.shields.io/endpoint?url=https://zelda64.dev/assets/csv/progress-oot-shield.json
|
||||||
|
|
|
@ -61,9 +61,9 @@ If you can't match a function even with everyone's, don't worry overlong about i
|
||||||
|
|
||||||
Run the formatting script `format.py`, to format the C files in the standard way we use.
|
Run the formatting script `format.py`, to format the C files in the standard way we use.
|
||||||
|
|
||||||
### Merge master
|
### Merge main
|
||||||
|
|
||||||
To make sure the PR builds correctly with the current master, you need to merge `upstream/master` before you make the PR. This tends to break things, that you have to fix to get it to compile correctly again.
|
To make sure the PR builds correctly with the current main, you need to merge `upstream/main` before you make the PR. This tends to break things, that you have to fix to get it to compile correctly again.
|
||||||
|
|
||||||
## Pull Requests
|
## Pull Requests
|
||||||
|
|
||||||
|
@ -81,7 +81,7 @@ and so on, although these four tend to cover most cases. Feel free to add a comm
|
||||||
|
|
||||||
Pull requests may be reviewed by anyone (who knows enough about the conventions of the project), but all are usually reviewed by Fig and Roman.
|
Pull requests may be reviewed by anyone (who knows enough about the conventions of the project), but all are usually reviewed by Fig and Roman.
|
||||||
|
|
||||||
To implement suggestions made in reviews, it is generally easier to be consistent if you push more commits from your local branch. It is quite possible that in the meantime some other PR has gone in, and git will ask you to merge master before you add more commits. This is normally fairly painless, although often you have to resolve merge conflicts. If in doubt, backup your work before doing anything, and ask in Discord before doing anything drastic, or if you don't understand what git is telling you.
|
To implement suggestions made in reviews, it is generally easier to be consistent if you push more commits from your local branch. It is quite possible that in the meantime some other PR has gone in, and git will ask you to merge main before you add more commits. This is normally fairly painless, although often you have to resolve merge conflicts. If in doubt, backup your work before doing anything, and ask in Discord before doing anything drastic, or if you don't understand what git is telling you.
|
||||||
|
|
||||||
There is no need to wait for your PR to be approved and committed before working on your next actor.
|
There is no need to wait for your PR to be approved and committed before working on your next actor.
|
||||||
|
|
||||||
|
@ -94,4 +94,4 @@ It's helpful to use the labels on Trello.
|
||||||
- Matched for when it is totally decompiled and matching
|
- Matched for when it is totally decompiled and matching
|
||||||
- Documented if at least everything is named and odd code is commented. We'll likely wipe these and start over when proper documentation begins.
|
- Documented if at least everything is named and odd code is commented. We'll likely wipe these and start over when proper documentation begins.
|
||||||
|
|
||||||
We now have a PR label on the Trello that you can use to indicate your actor is in a PR. When the actor is committed to master, you can move the actor into the `Decompiled Files (Overlays)` column: it goes at the top if there is a non-matching, and below if not.
|
We now have a PR label on the Trello that you can use to indicate your actor is in a PR. When the actor is committed to main, you can move the actor into the `Decompiled Files (Overlays)` column: it goes at the top if there is a non-matching, and below if not.
|
||||||
|
|
|
@ -10,7 +10,7 @@ This is covered on the main page of the repository.
|
||||||
|
|
||||||
First, make a GitHub fork of the repository, then clone it into a git-enabled local folder.
|
First, make a GitHub fork of the repository, then clone it into a git-enabled local folder.
|
||||||
|
|
||||||
Once you have decided on an actor, you should make a new git branch to work on: your master branch is meant to stay level with the main repository. Name it something sensible: my `EnFirefly` branch is called "en_firefly", for example, but you may prefer to use a more descriptive name: "Dark_Link" is rather more suggestive than "en_torch2", for example. You work on the branch, commit changes, and periodically push them to GitHub, if only for backup purposes.
|
Once you have decided on an actor, you should make a new git branch to work on: your main branch is meant to stay level with the main repository. Name it something sensible: my `EnFirefly` branch is called "en_firefly", for example, but you may prefer to use a more descriptive name: "Dark_Link" is rather more suggestive than "en_torch2", for example. You work on the branch, commit changes, and periodically push them to GitHub, if only for backup purposes.
|
||||||
|
|
||||||
Once you have finished an actor, you submit a pull request for other people to check your work complies with the project's conventions, and once it is deemed satisfactory, it will be merged in to the main repository.
|
Once you have finished an actor, you submit a pull request for other people to check your work complies with the project's conventions, and once it is deemed satisfactory, it will be merged in to the main repository.
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue