1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2024-11-26 02:04:18 +00:00
oot/asm/non_matchings/overlays/actors
Kenix3 f4499a8de2
En_Clear_Tag OK and documented (#689)
* Decompile and document En_Clear_Tag

* Adds a define for setting the total count of ClearTag particles.

* Fixes swap in particle effect struct member names.

Additionally, implements the DECR macro where available.
Additionally, implements the CLAMP_MIN macro.
Additionally, adds more comments inside of functions explaining how the Arwing works.

* Reformats z_en_clear_tag.c after recent fixes.

* Removes not OK DECR and CLAMP_MIN macros.

I don't know why they built locally OK for me. May have had a stale build.

* Added static to data declarations.

Additionally added white spacing between data definitions.

* Various syling fixes in EnClearTag

Fixes inconsistent usage of particle/effect. They're Effect is the better name, so I went with that.

Fixed a naming issue in CalculateFloorTangent.

Adds s prefix to all the static variables.

Renames clearTagParticlesBuffer to sClearTagEffects

Consistent capitalization in comments.

Adds more descriptive comments to function level comments that didn't say a lot already.

Renamed gameplay.particleEffects to gameplay.specialEffects.

Renames cameraNumber to cameraId.

Fixed capitalization in display list variable names.

* Always capitalize the A in arwing.

* Fixes issue with overzealous replacement of arwing -> Arwing

* Renames arwing display lists to include the g prefix.

* Renames effect seed -> random

* Removes unnecessary decrement timer comments.

* Updates Arwing comments to detail why it's important that the roll is updated to zero.

* Updates stack variable names in EnClearTag_Update to be more consistent with each other.

* Updates Arwing crashing documentation.

* Further update documentation on arwing crashing.

* Even further updates to Arwing crashing docs.

* Fixes issue of missing newline in En_Clear_Tag.xml

* targetDirection reset now has a chained assignment

* Rotation angle to hex

* Fixes rotation hex and identifies float.

* Updates arwing fire check.

* Arwing cutscene timer is multiplied by 128 rather than shifting 7

* Updates scaledCrashingTimer assignment to be more consistent.

* Updates max scale to multiply by 2

* Gives name to the work buffer indices.

Additionally, makes enum names more consistent.

* Removes unnecessary globalCtx2 in EnClearTag_CreateFlashEffect

* Runs format.sh after recent changes.

* Updated path of ClearTag assets.

* Clear tag now uses Arwing in the display list name for all effects.

* Updates work buffer to expand and contract as new enums are added.

* Uses c99 defines in my c89

* Updates the unknown 8 bytes in en_clear_tag

* review

Co-authored-by: fig02 <fig02srl@gmail.com>
2021-03-29 19:14:08 +02:00
..
ovl_Bg_Gnd_Firemeiro Demo_Kekkai, its object, and its cutscenes (#627) 2021-02-01 14:52:23 -05:00
ovl_Bg_Hidan_Sekizou object_hidan_objects OK (#695) 2021-03-18 03:23:59 -04:00
ovl_Bg_Jya_Cobra Decompile Bg Jya Cobra (#588) 2021-01-21 09:55:11 -05:00
ovl_Bg_Mizu_Movebg Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_Bg_Spot02_Objects Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_Bg_Spot07_Taki z_bgcheck.c, 800430A0.c, 80043480.c (#256) 2021-01-08 06:12:58 -05:00
ovl_Bg_Sst_Floor Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_Bg_Toki_Hikari Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Bg_Vb_Sima z_bgcheck.c, 800430A0.c, 80043480.c (#256) 2021-01-08 06:12:58 -05:00
ovl_Boss_Dodongo Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Fd Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Fd2 Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Ganon Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Ganon2 Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Ganondrof Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Goma Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Mo Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Sst Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_Boss_Tw Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Boss_Va Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Demo_6K ovl_Demo_6K (#726) 2021-03-29 00:40:38 +02:00
ovl_Door_Warp1 Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Efc_Erupc Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_En_Bdfire Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_En_Bigokuta Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Daiku ovl_En_Daiku OK and documented (#422) 2020-12-03 16:58:05 -05:00
ovl_En_Dekubaba Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Diving_Game Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_En_Eiyer Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Elf Three new matching functions (#492) 2020-11-19 16:49:08 -05:00
ovl_En_fHG Docs for the Anime part of SkelAnime (#517) 2020-12-29 17:46:46 -05:00
ovl_En_Fhg_Fire Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_En_Fish Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
ovl_En_Ganon_Mant Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_En_Goma Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_En_Holl decompile z_camera (#398) 2020-12-06 17:39:47 -05:00
ovl_En_Horse Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_En_Jsjutan ovl_En_Jsjutan with 1 non_matching (#713) 2021-03-27 22:47:25 -04:00
ovl_En_Ko Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_En_M_Thunder Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
ovl_En_Ossan Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
ovl_En_River_Sound z_bgcheck.c, 800430A0.c, 80043480.c (#256) 2021-01-08 06:12:58 -05:00
ovl_En_Skb z_en skb, 1 non-matching, with some documentation (#669) 2021-02-15 17:52:22 -05:00
ovl_En_Skj Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_En_Test Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Tg Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_En_Torch2 Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Tp Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Tr EnTr, 1 nonmatching, mostly documented (#621) 2021-01-31 00:07:58 -05:00
ovl_En_Vali Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Vb_Ball Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
ovl_En_Wf Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_En_Xc Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_En_Yabusame_Mark ovl_en_yabusame_mark, 1 nonmatching (#707) 2021-02-21 19:10:24 -05:00
ovl_En_Zf Armos and object_am OK (#652) 2021-02-15 19:41:55 +01:00
ovl_Fishing Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_kaleido_scope Rename Matrix_Pull to Matrix_Pop (#703) 2021-02-24 14:28:04 -05:00
ovl_Obj_Bean Actor Struct Changes (and a few related things) (#617) 2021-01-18 16:04:04 -05:00
ovl_Obj_Lift z_bgcheck.c, 800430A0.c, 80043480.c (#256) 2021-01-08 06:12:58 -05:00
ovl_Obj_Mure Consistent naming for Math_ functions (#542) 2020-12-26 05:44:53 -05:00
ovl_Object_Kankyo Demo_Kekkai, its object, and its cutscenes (#627) 2021-02-01 14:52:23 -05:00