1
0
Fork 0
mirror of https://github.com/zeldaret/oot.git synced 2024-11-11 03:39:59 +00:00
oot/data/overlays/actors
Kenix3 f4499a8de2
En_Clear_Tag OK and documented (#689)
* Decompile and document En_Clear_Tag

* Adds a define for setting the total count of ClearTag particles.

* Fixes swap in particle effect struct member names.

Additionally, implements the DECR macro where available.
Additionally, implements the CLAMP_MIN macro.
Additionally, adds more comments inside of functions explaining how the Arwing works.

* Reformats z_en_clear_tag.c after recent fixes.

* Removes not OK DECR and CLAMP_MIN macros.

I don't know why they built locally OK for me. May have had a stale build.

* Added static to data declarations.

Additionally added white spacing between data definitions.

* Various syling fixes in EnClearTag

Fixes inconsistent usage of particle/effect. They're Effect is the better name, so I went with that.

Fixed a naming issue in CalculateFloorTangent.

Adds s prefix to all the static variables.

Renames clearTagParticlesBuffer to sClearTagEffects

Consistent capitalization in comments.

Adds more descriptive comments to function level comments that didn't say a lot already.

Renamed gameplay.particleEffects to gameplay.specialEffects.

Renames cameraNumber to cameraId.

Fixed capitalization in display list variable names.

* Always capitalize the A in arwing.

* Fixes issue with overzealous replacement of arwing -> Arwing

* Renames arwing display lists to include the g prefix.

* Renames effect seed -> random

* Removes unnecessary decrement timer comments.

* Updates Arwing comments to detail why it's important that the roll is updated to zero.

* Updates stack variable names in EnClearTag_Update to be more consistent with each other.

* Updates Arwing crashing documentation.

* Further update documentation on arwing crashing.

* Even further updates to Arwing crashing docs.

* Fixes issue of missing newline in En_Clear_Tag.xml

* targetDirection reset now has a chained assignment

* Rotation angle to hex

* Fixes rotation hex and identifies float.

* Updates arwing fire check.

* Arwing cutscene timer is multiplied by 128 rather than shifting 7

* Updates scaledCrashingTimer assignment to be more consistent.

* Updates max scale to multiply by 2

* Gives name to the work buffer indices.

Additionally, makes enum names more consistent.

* Removes unnecessary globalCtx2 in EnClearTag_CreateFlashEffect

* Runs format.sh after recent changes.

* Updated path of ClearTag assets.

* Clear tag now uses Arwing in the display list name for all effects.

* Updates work buffer to expand and contract as new enums are added.

* Uses c99 defines in my c89

* Updates the unknown 8 bytes in en_clear_tag

* review

Co-authored-by: fig02 <fig02srl@gmail.com>
2021-03-29 19:14:08 +02:00
..
z_bg_gnd_firemeiro.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_gnd_firemeiro.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_hidan_sekizou.data.s object_hidan_objects OK (#695) 2021-03-18 03:23:59 -04:00
z_bg_hidan_sekizou.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_jya_cobra.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_mizu_movebg.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_mizu_movebg.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_mizu_movebg.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_spot02_objects.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_spot02_objects.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_spot07_taki.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_spot07_taki.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_sst_floor.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_sst_floor.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_toki_hikari.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_toki_hikari.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_vb_sima.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_bg_vb_sima.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_dodongo.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_dodongo.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_fd.data.s Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
z_boss_fd.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_fd2.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_fd2.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganon.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganon.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganon.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganon2.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganon2.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganon2.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganondrof.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_ganondrof.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_goma.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_goma.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_mo.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_mo.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_mo.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_sst.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_sst.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_sst.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_tw.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_tw.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_tw.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_va.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_va.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_boss_va.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_demo_6k.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_door_warp1.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_door_warp1.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_door_warp1.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_efc_erupc.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_efc_erupc.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_bdfire.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_bdfire.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_bigokuta.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_bigokuta.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_daiku.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_dekubaba.data.s Remove some unaligned fake symbols (#535) 2020-12-16 22:10:42 -05:00
z_en_dekubaba.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_diving_game.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_diving_game.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_eiyer.data.s Remove some unaligned fake symbols (#535) 2020-12-16 22:10:42 -05:00
z_en_eiyer.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_elf.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_fhg.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_fhg.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_fhg_fire.data.s Decompile ovl_En_Fhg_Fire (#248) 2020-07-16 06:02:27 -04:00
z_en_fhg_fire.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_fish.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_fish.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ganon_mant.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ganon_mant.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ganon_organ.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ganon_organ.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_goma.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_goma.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_holl.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_horse.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_horse.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_jsjutan.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ko.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ko.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_m_thunder.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ossan.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_ossan.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_river_sound.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_river_sound.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_skb.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_skj.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_skj.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_skj.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_skj.rodata.s Split remaining unsplit asm files and migrate more rodata (#277) 2020-07-19 21:08:50 -04:00
z_en_test.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_test.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_tg.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_tg.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_torch2.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_tp.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_tp.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_tr.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_vali.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_vali.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_vb_ball.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_vb_ball.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_wf.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_wf.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_xc.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_xc.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_xc.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_yabusame_mark.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_zf.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_zf.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_en_zf.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_fishing.bss.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_fishing.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_fishing.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_kaleido_collect.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_kaleido_debug.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_kaleido_equipment.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_kaleido_item.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_kaleido_map_PAL.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_kaleido_scope.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_kaleido_scope_PAL.bss.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_kaleido_scope_PAL.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_lmap_mark.data.s Split ovl_file_choose and ovl_kaleido_scope (#167) 2020-06-07 13:52:43 -04:00
z_lmap_mark.rodata.s Migrated rodata (#199) 2020-06-09 12:06:23 -04:00
z_obj_bean.data.s Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
z_obj_bean.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_obj_lift.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_obj_lift.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_obj_mure.data.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_obj_mure.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00
z_object_kankyo.data.s Decompile Gameplay_Keep and fix all existing decompiled objects (#595) 2021-01-24 19:36:40 -05:00
z_object_kankyo.reloc.s Properly align asm & data (+ minor fixes) (#165) 2020-05-26 18:09:00 -04:00