fig02
afbc312024
Rename "Scene Setup Index" to "Scene Layer" ( #1300 )
...
* setup -> layer
* IS_CUTSCENE_LAYER
* review
* backtick
* remove some more mentions of setup
* alt header block
* clarifying comment
2022-07-30 17:28:50 -04:00
Tharo
d7ea63c75d
Fix format.py for python 3.6 ( #1337 )
2022-07-30 22:53:31 +02:00
Tharo
97e795fc0e
Cleanup libultra controller routines ( #1312 )
...
* Cleanup libultra controller routines
* Correct structure name
* Fixes + Suggestions
* Move READFORMAT macro to controller.h
2022-07-30 15:41:32 -04:00
Dragorn421
2f5eac6b76
Move fault_drawer bss to data/ asm because -g3 bss is fun ( #1335 )
2022-07-30 10:09:42 -04:00
Roman971
0ce2e75560
Rewrite format script in python to improve speed with multiprocessing ( #1331 )
...
* Rewrite format script in python to improve speed with multiprocessing
* Make format.py executable
2022-07-30 09:24:52 -04:00
engineer124
1d19f37b26
Rename "Sound" to "Sfx" ( #1292 )
...
* First attempt
* More
* rename
* more sound -> sfx / sound effect (#7 )
* PR Suggestions
* PR Suggestions
* Small fix
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: fig02 <fig02srl@gmail.com>
2022-07-30 09:05:27 -04:00
Roman971
1652b7e5d7
Fix audio strings with -use_readwrite_const and -signed ( #1324 )
...
* Fix audio strings with -use_readwrite_const and -signed
* Add comments for audio flags in makefile
2022-07-29 20:35:09 -04:00
Roman971
7254adec9f
Use intptr types in overlays and dmadata ( #1325 )
2022-07-29 20:29:48 -04:00
krm01
3122143f96
[Doc] actor En_Skb (Stalchild) ( #1299 )
...
* en_skb stalchild actor doc
* missed a sneaky one
* rename Main to DecideNextAction
* action state rename and become enum
* tweak bodybreak comment
* rename SPAWNING to BURIED
* rename to headlessWalkYawOffset
* rename hitboxActive to enableATCollision
* use bools for enableATCollision
* formatting
* move EnSkbActionState out of header
* rename enableATCollision -> setColliderAT
* remove unnecessary prototypes
* renaming per review, settle on breakFlags
2022-07-28 03:02:46 -04:00
engineer124
423fec9f79
Clean up audio sample counts: bytes, samples, frames ( #1289 )
...
* Clean up bytes, samples, frames
* Improve macro usage
* More missed macros
* rename macro now that it crosses files
* redefine macros in terms of frames
* Another use of macro
* Fix, it's number of samples, not size
* Partial PR Suggestions
* Small change
* size to length
* Correct/Clarify comments
* remove comment
* More PR suggestions, cleanup
* Bad formatting, fixed
2022-07-27 17:53:56 -04:00
mzxrules
ffcbc0de79
Fix TEXTBOX_POS issue ( #1329 )
2022-07-27 16:24:58 -04:00
Dragorn421
9647f50451
Cleanup z_debug (reg editor) ( #1290 )
...
* Cleanup z_debug
* misc
* pad reg names column to """allow""" 40 characters because why not
* safety parentheses in regs.h
* More safety parentheses, in named regs defines
* sort named regs in order, except for message system regs (?)
* put all regs in order (message system ones too)
2022-07-14 19:02:07 -04:00
engineer124
79cb1f8d5c
Misc Cleanup/Docs ( #1315 )
...
* Misc Cleanup
* More cleanup
2022-07-14 16:26:10 -04:00
Charles Averill
cf52184766
Name EnMd limb indices ( #1314 )
2022-07-14 20:37:23 +02:00
Derek Hensley
beb56ad27a
Better AudioMgr_StopAllSfx match ( #1316 )
...
* Better AudioMgr_StopAllSfx match
* Use same temp name
* remove volatile
2022-07-13 14:20:36 -04:00
Derek Hensley
354a2c29f8
object_cne ( #1310 )
2022-07-12 22:26:49 -04:00
Roman971
7564502b0b
Use intptr types in a few specific boot files ( #1301 )
...
* Add stdint.h with intptr_t and uinptr_t
* Use intptr types in dmamgr and yaz0
* Use intptr types in stackcheck
* Use intptr types in idle
* Run formatter
* Use pointers for StackEntry (+ minor type fix)
2022-07-12 12:47:25 -04:00
Dragorn421
2f07874a5f
Remove BINANG_SUB ( #1297 )
2022-07-12 12:17:07 -04:00
engineer124
c27e292929
Introduce Sfx Tables ( #1296 )
...
* sfx tables
* return audio sound params
* Add docs for tables
* REF -> BASE
* Fix description
* Small fix
* Reorder phrase
* Return sfx.h
* Better docs
* Roman PR Suggestions
2022-07-11 13:45:22 -04:00
Derek Hensley
8607c54e75
BossDodongo_OverrideLimbDraw Better match? ( #1322 )
...
* Better match?
* Update src/overlays/actors/ovl_Boss_Dodongo/z_boss_dodongo.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
2022-07-11 19:24:30 +02:00
engineer124
66946534a1
Audio Misc Cleanup 2 ( #1303 )
...
* Misc cleanup
* PR Suggestions
2022-07-04 12:19:39 -04:00
engineer124
8778bf09b5
Introduce Mutebehavior Flags ( #1304 )
...
* Add muteBehavior flags
* touchup
* Adjust comment
2022-07-04 12:00:29 -04:00
engineer124
f2d4c3b10b
Document code_800C3C20: Audio_StopAllSfx ( #1309 )
...
* Document code_800C3C20
* Associate it with AudioMgr to separate it from the audio library
2022-07-04 11:51:38 -04:00
Dragorn421
ed0ab877c9
Some names and docs on dynapoly ( #1287 )
...
* Add `BG_DYNA_ACTOR_FLAG_` for `DynaCollisionContext.bgActorFlags`
* Document 3/4 bgActor flags
* `func_8003EE6C` -> `DynaPoly_InvalidateLookup`
* `DynaPoly_ExpandSRT` -> `DynaPoly_AddBgActorToLookup`
* Add `DYNAPOLYACTOR_UNK160_` for `DynaPolyActor.unk_160`
* More dynapoly docs
* One comment
* Some `DynaPoly_` -> `DynaPolyActor_`
* run formatter
* .
* `BG_DYNA_ACTOR_FLAG_IS_USED` -> `BG_DYNA_ACTOR_FLAG_IN_USE`
* `BG_DYNA_ACTOR_FLAG_` -> `BGACTOR_`
* `DYNAPOLYACTOR_INTERACT_FLAG_` -> `DYNA_INTERACT_`
* `ResetInteractFlags` -> `ClearInteractFlags`
* Remove Has/Is prefix on dyna interact flags getters
* format
* remove now useless comments
* Remove `!= 0` on interact flags getter usage
* ceilings collision -> ceiling collision
* `ClearInteractFlags` -> `UnsetInteractFlags` (pepega)
* `UnsetInteractFlags` -> `UnsetAllInteractFlags` (pepega x2)
* Add back `Is` prefix (no `Has` this time) to dyna interact flags getters
2022-06-25 09:53:26 -04:00
Dragorn421
397e481f9a
Fix misc 15 ( #1298 )
...
* Use `SCENE_` enum more
* Decimal for pos in `D_8011F9B8`
* `__osEventStateTab`: length `OS_NUM_EVENTS + 1` -> `OS_NUM_EVENTS`
* thone -> throne
* `s` on local data
* minor sfxId cleanup
* Run formatter
* Fixup 0x19 + 1 = 0x1A, not 0x20 lol
* Tlut -> TLUT
* DemoKankyo params usage cleanup
* Some proofreading (up to z_actor.c)
* Revert 0 -> sfxId, add todo comment (sfxId=0 is weird apparently)
* `sZdWaterBox` -> `sZorasDomainWaterBox`
* `msgMode == MSGMODE_`, not `GAMEMODE_` (my bad Sadge)
2022-06-24 19:45:05 -04:00
engineer124
fe7afb9b07
Document File-Select Audio Settings: Sound Modes ( #1281 )
...
* Round 1
* Cleanup
* Cleanup
* Space
* More spacing
* Apply -> Set (consistency)
* round 1 pr
* Revert some names
2022-06-24 19:27:54 -04:00
Dragorn421
984871eb38
Document SaveContext.gameMode ( #1295 )
...
* Document `SaveContext.gameMode`
* end credits
* Remove no longer needed comment
2022-06-23 21:32:48 -04:00
Dragorn421
e16779cc33
Rename game states ( #1294 )
...
* `TitleSetup` -> `Setup`
* `Title` -> `ConsoleLogo`
* `Opening` -> `TitleSetup`
* `FileChoose` -> `FileSelect`
* `Select` -> `MapSelect`
* prenmi/sample `Context` -> `State`
* Revert filename changes
* .
* setupstate cleanup
* Oops, `GameState` -> `SetupState`
2022-06-23 23:34:26 +02:00
Dragorn421
81ab6fe831
Remove BINANG_ROT180 ( #1241 )
2022-06-22 16:10:01 -04:00
fig02
e4884e0cb9
Introduce PLAY_LOG() ( #1284 )
...
* play log
* review, try to compromise on comment
* another compromise attempt
* new comment
* remove comma
* fix
2022-06-21 19:25:09 +02:00
engineer124
5dda2f9ffc
audio_seqplayer.c cleanup ( #1274 )
...
* Audio Seqplayer Cleanup
* More
* Edit description
* PR Suggestions
* while true
* Cleanup function declarations
* Extra space, oops
* Small fix
* PR Suggestions
* tatums per beat
* Edit comment
2022-06-21 04:42:02 -04:00
engineer124
00b98027db
Synthetic Waves Documentation ( #1256 )
...
* Synthetic wave documentation
* Better docs
* harmonicIndex
* More
* typo
* Complete the abi buffer docs
* Small change
* Revert change
* PR suggestions
* Missed one
* PR Feedback
* Better documents
* Well that was a silly copy-pasta mistake
* Typo
* Another comment
* Plural
* Make it more block-like
* Capitalization
* Add comments for gWaveSamples[8]
* Adjust comment
* More PR Suggestions
* PR Suggestions
* missed a phrasing
* PR Suggestions
* Update include/z64audio.h
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2022-06-20 21:55:01 -04:00
engineer124
e7e2da86a8
Remove OoB SfxIds ( #1291 )
2022-06-20 21:32:17 -04:00
engineer124
d88a23f4a0
Document Viewpoints and Scene Cam Types ( #1285 )
...
* Document bgCamData
* More changes and cleanup
* More docs
* Clarify comments
* PR Feedback, rename bgcheck functions
* remove fallthrough cleanup (other pr that deals with that)
* PR Suggestions
* bug report
* bgCamDataIndexBeforeUnderwater
* PR/Discord Discussions
* Missed some
* sync function header args
* Another suggestion
* cleanup
* Comments
* Indoor BgCamData
* Change bgCamData to s16 for now
* PR suggestions
* the
* use "info"
* Missed a suggestion
* Update and sync docs
* More docs
* Even more docs
* Revert macro
* Add comment
* Better comments
* More cleanup
* Better Cam Scene Docs
* Small change
* Market -> Pivot
* "only"
* swap
* Better comment
* Another comment
* to
* Implement suggestions from discord
* Discord Discussion
* Revert bgCamFuncData to Vec3s
* cleanup
* Remaining cleanup
* docs cleanup
* format
* More docs
* Improve notes
* Cleanup
* Change enum
* PR Suggestions
* Improve comment
* Rephrase
* Implement discussion from discord
* Discord discussion
* fixed to locked
* Update comments
* Few more comments
* Update include/z64.h
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Update include/z64camera.h
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Better comments
* PR Suggestions
* rm numbers
* Update src/code/z_play.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2022-06-20 20:31:53 -04:00
Roman971
6d52684020
Format script improvements and use strict name checks ( #1275 )
...
* Prioritize using clang-tidy 6 and improve format.sh
* Use clang-tidy-6.0 when available since it's better at applying 'readability-inconsistent-declaration-parameter-name'
* Add -m32 and -Wno-everything to compiler options to avoid unwanted errors and warnings
* Remove -fsyntax-only since it serves no purpose in the context of clang-tidy
* Apply clang-tidy fixes for argument names
* Run format.sh again
* Use 'Strict' option instead of relying on clang-tidy 6
* Run format script
* Add --fix-notes to clang-tidy options for version 13+
2022-06-20 16:31:53 -04:00
Dragorn421
017a3aaf5c
Some doc on actor overlays alloc types ( #1266 )
...
* Some doc on actor overlays alloc types
* Line breaks between defines at the top of actor.h
* plain english
* `ACTOR_ALLOC_` -> `ACTOROVL_ALLOC_`
* More line breaks
* `ACTOR_OVERLAY_ABSOLUTE_SPACE_SIZE` -> `ACTOROVL_ABSOLUTE_SPACE_SIZE`
* Document bug about Scarecrow's Song not setting the flag to restore Nayru's Love
* Try to document the check for needing to actor_kill to leave the absolute space being too broad
* "which overlay uses" (bad english) -> simplify to "which uses"
* Run formatter
2022-06-20 16:17:09 -04:00
engineer124
b602276fef
Introduce Sfx Flags ( #1278 )
...
* Sfx Flags
* Discord Discussion
* Move macro to sound_params
* Oops
* PR Suggestions
* Clarify comment
* Missed switch
* More suggestions
* Update src/code/audio_sound_params.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* sfxs
* PR Suggestions
* revert back to flag
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2022-06-20 14:24:21 -04:00
louist103
56e52a89c1
Extract skyboxes and backgrounds ( #1252 )
...
* xmls
* cleanups
* final cleanups
* tlut -> TLUT
* remove number 0
Co-authored-by: fig02 <fig02srl@gmail.com>
2022-06-19 10:39:39 -04:00
engineer124
38de9405e6
Restructuring SoundFont Structs ( #1277 )
...
* Document fontData relocation
* Fix
* More cleanup
* typo
* sample -> sampleHeader
* Revert name
* Just a little more
* Another comment change
* Fix Drum
* fix
* K0BASE
* Update relocs
* consistency
* clearer phrasing
* Fix
* PR/Discord Suggestions
* typo
* Revert Sound Font Sample Struct for another PR
* Missed a function
* Organize structs, tuned samples
* New sound effects struct
* fix func name
* wave samples
* consistency
* Fix
* More suggestions
* PR Suggestions
* sample bank reloc
* Revert header description
* better text
* SoundFount Relocation: some cleanup (#6 )
* `fontDataStartAddr` for relocation, `fontData` for reading data (`AudioLoad_RelocateFont`)
* Comment "cleanup" in `AudioLoad_RelocateFont`
* Comment "cleanup" in `AudioLoad_RelocateSample`
* Cleanup cast and compares to 0 (offsets) / NULL (pointers)
* Cleanup
* soundFont info
* Revert waveSamples
* cleanup
* Plural
* PR suggestions
* A few name changes and suggestions
* small changes
* Drop Info on SoundFont
* Missed some
* One more function change
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2022-06-19 16:31:08 +02:00
engineer124
849fdbf9ea
Document Camera BgCamData ( #1232 )
...
* Document bgCamData
* More changes and cleanup
* More docs
* Clarify comments
* PR Feedback, rename bgcheck functions
* remove fallthrough cleanup (other pr that deals with that)
* PR Suggestions
* bug report
* bgCamDataIndexBeforeUnderwater
* PR/Discord Discussions
* Missed some
* sync function header args
* Another suggestion
* cleanup
* Comments
* Change bgCamData to s16 for now
* PR suggestions
* the
* use "info"
* Missed a suggestion
* Discord Discussion
* Revert bgCamFuncData to Vec3s
* format
2022-06-17 20:25:42 +02:00
Roman971
08c8126ba5
Enable int-conversion warnings and fix all current instances ( #1280 )
...
* Enable int-conversion warnings for gcc/clang
* Fix all current int-conversion warnings
* Run format.sh
* Apply review suggestions
2022-06-15 20:15:44 -04:00
Dragorn421
5299208291
Macros for Entranceinfo.field ( #1270 )
...
* Macros for `Entranceinfo.field`
* `ENTRANCE_INFO_FIELD_` -> `ENTRANCE_INFO_`
* Remove mentioning the transition types being "default"
* comment on macros what they are for
* Shorten "transition" -> "trans" for `EntranceInfo.field` usage
2022-06-15 20:41:47 +02:00
EllipticEllipsis
030594a457
Actor prototype cleanup ( #1276 )
...
* Fix some ActorFunc prototypes
* Add defaults to switches in object_kankyo
2022-06-13 18:25:02 +02:00
Dragorn421
0832b5af68
Fix misc 14 ( #1279 )
...
* Remove fake temp in `BossDodongo_DrawEffects`
* `OS_WRITE` for `__osSpRawStartDma` `direction`
* remove outdated comment
* fixup osRecvMesg
* make sShopkeeperStores static
* `PHYSICAL_TO_VIRTUAL(gSegments[0])` -> `SEGMENTED_TO_VIRTUAL(NULL)` (mimics `CollisionHeader_SegmentedToVirtual`)
* Run formatter
* Remove assets from include path in suggested vscode properties
* Fix `osCreateMesgQueue` getting `OS_MESG_BLOCK` as `count` instead of `1`
2022-06-13 17:38:20 +02:00
engineer124
93a6a1eb9a
Audio_Init_Params.c Cleanup ( #1273 )
...
* Document Audio Heap Init Sizes
* Swap order
* Another small change
* Another
* Plural
* swap order
* Reverb Settings
* Return comment
* more cleanup
* Fix data names
2022-06-12 19:47:53 -04:00
engineer124
605f13327a
Document SoundFont Relocation ( #1237 )
...
* Document fontData relocation
* Fix
* More cleanup
* typo
* sample -> sampleHeader
* Revert name
* Just a little more
* Another comment change
* Fix Drum
* fix
* K0BASE
* Update relocs
* consistency
* clearer phrasing
* Fix
* PR/Discord Suggestions
* typo
* Revert Sound Font Sample Struct for another PR
* Missed a function
* PR Suggestions
* sample bank reloc
* Revert header description
* better text
* SoundFount Relocation: some cleanup (#6 )
* `fontDataStartAddr` for relocation, `fontData` for reading data (`AudioLoad_RelocateFont`)
* Comment "cleanup" in `AudioLoad_RelocateFont`
* Comment "cleanup" in `AudioLoad_RelocateSample`
* Cleanup cast and compares to 0 (offsets) / NULL (pointers)
* Cleanup
* Edit comments
* phrasing
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2022-06-12 19:33:56 -04:00
Roman971
feadb0d9ee
Enable more IDO warnings and apply fixes ( #1264 )
...
* Update asm-processor and fix includes with EARLY
* Enable more IDO warnings and disable unwanted warning 516
* Fix most new and remaining warnings
* Improve skelanime comment
* Improve asmproc pragma comment
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* Add suggested comment for a wrong prototype
* Update asm-processor with the latest fix
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
2022-06-12 19:24:45 -04:00
Kenton M
4cb1c3345f
Small doc for Item00 actor ( #1268 )
...
* EnItem00.unk_15A rename to despawnTimer
* func_8001E5C8 rename to EnItem00_BounceAfterCollected
* shorten to Item00_Collected
2022-06-12 19:15:15 -04:00
EllipticEllipsis
be57b6bf4c
Document flag for swinging bottle ( #1272 )
...
* Document flag for swinging bottle
* Add bug, minor documentation to func_8084ECA4
* Update comments
* Add newline to z64cutscene_commands.h
* Review
2022-06-12 18:58:13 -04:00
Roman971
826924afea
Fix clang compilation error due to a fallthrough ( #1271 )
2022-06-11 10:19:34 -04:00
