Yanis42
21cb04db2c
Document `z_bg_mizu_movebg.c` ( #1565 )
...
* document z_bg_mizu_movebg.c + assets
* remove temp comment
* renamed "temp" variable
* review 1
* format + type names comments at dLists/colHeaders
* review 2
* review 3
* named dragon statue 1
* float -> floating + review
* format
* review 5
2023-12-15 15:33:50 -05:00
fig02
2b5b0fac06
name shock and burn functions ( #1594 )
2023-12-15 08:53:51 -05:00
krm01
e3316c9fb1
[Doc] Actor Bg_Bdan_Objects (Jabu Jabu misc dungeon actors) ( #1577 )
...
* bdan_objects type 2
* other bdan object types
* finish off bigocto platform
* run formatter
* remove stray comment
* add namespacing prefix to enums
* abbreviate camera to cam
* Update src/overlays/actors/ovl_Bg_Bdan_Objects/z_bg_bdan_objects.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* fix typo on enum
* Update src/overlays/actors/ovl_Bg_Bdan_Objects/z_bg_bdan_objects.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Update src/overlays/actors/ovl_Bg_Bdan_Objects/z_bg_bdan_objects.h
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* enum name fixes
* remove unnecessary enum assignment
* Waterbox -> WaterBox
* named union, sfx to use SFX_FLAG
* friendly names for enums
* fix over-eager sed rename
* indent union fields
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-12-11 10:55:35 -05:00
fig02
0ed57f61b7
Cleanup: Remove uneeded casts on collider members ( #1595 )
...
* rm casts
* format
2023-12-10 14:53:51 -05:00
hiisuya
cc96184a96
Doc Actor: En_Ma1 (Child Malon) ( #1584 )
...
* started malon documentation
* docd all event and inf table checks
* doc cleanup
* ran formatter
* fixed misnamed eventcheck
* revert isNotSinging oops
* removed unnecessary comments
* changed from handle to update
* revert vec3f name change
* moved texture information
* isNotSinging to singingDisabled
* rename of inftable and eventchk
* small cleanup
* anim enum change
* enum names for child malon limbs
2023-12-10 14:36:12 -05:00
cadmic
2ab90bc517
Document a bug in Actor_ChangeCategory where actors may not be updated correctly ( #1587 )
...
* Document Actor_ChangeCategory bug
* Reword
* actor update function -> actor update
2023-11-30 20:18:00 -05:00
Tharo
5ce4670fd1
Documentation for audio_thread_manager.c ( #1562 )
...
* Documentation for audio_thread_manager.c
* Fixes
* Move AudioTask back to z64audio.h and include in audiomgr.h, adjust bug comment
* Adjust AudioMgrDebugLevel enum
2023-11-30 16:22:30 -05:00
engineer124
f2c06ce441
Misc Cleanup ( #1585 )
...
* misc cleanup
* more fake matches
* revert for sym
2023-11-22 04:19:31 -05:00
krm01
2aaa286cf8
[Doc] Actor Bg_Hidan_Fslift (Fire Temple hookshot elevator) ( #1579 )
...
* doc bg_hidan_fslift
* improve name for hookshot block pos function
* comment explaining cameraSetting
* improve comment
* Update src/overlays/actors/ovl_Bg_Hidan_Fslift/z_bg_hidan_fslift.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* rename to Idle
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-11-19 13:34:25 -05:00
engineer124
aef0335681
Struct Returns ( #1574 )
...
* change args
* PR Review
* format
2023-11-19 11:17:31 -05:00
engineer124
3d1ee33d7b
Document Actor "OfferTalk" ( #1567 )
...
* OfferTalk
* rm comment
* exch to offer in comment
* reword again
* Partial PR Review
* Actor_AcknowledgeTalking
* Actor_TalkOfferAccepted
* PR Review
* rm part of comment
* rm comment
2023-11-19 11:11:59 -05:00
fig02
c11ce9c994
Player Docs: Some Item Action function names ( #1575 )
...
* progress
* unname shield upper action
* add more to sword comment
2023-11-19 09:38:49 -05:00
hiisuya
68bdbf7759
Doc Actor: En_Brob (Jabu Jabu Wobble Flesh Block) ( #1581 )
...
* brob function naming
* modified brob header file
* renamed skel, collision, and anims
* named limbs and dls
* renamed shock function
* ran formatter
* doc modifications
* Update assets/xml/objects/object_brob.xml
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-11-19 05:11:52 -05:00
engineer124
81a3c3da32
More Camera Flags ( #1453 )
...
* Generic Camera Flags
* New flag names
* Add flags to functions
* Finish flag docs
* More docs
* More cleanup
* More clarity
* Better shrinkwindow flag docs
* Improve name
* CAM_INTERFACE_FLAGS
* Better approach to edge cases
* Change ordering for consistency
* Oops
* Add masks to macro
* PR/Discord discussions
* cleanup comment
* Oops
* PR Suggestions
* More PR Feedback
* More PR Suggestions
* More Camera Flags
* PR Suggestions
* More flag style change
* Small cleanup
* More flag docs
* Another flag
* Fix flags
* sync names with other PRs
* more fixes
* fix comments
* update with hud visibility mode docs
* missed one
* fix comments
* Roman PR Suggestions
* interfaceField
* small fix
* letterbox cleanup
* cleanup
* fix macro arg
* fix func declaration
* many more docs
* better docs?
* missed some
* oops, revert
* add flags to name
* cleanup
* flag
* double signal
* simplify cam func name
* more suggestions
* PR Suggestion
2023-11-19 02:17:32 +01:00
krm01
d1df4e4c7e
bombowlman typo ( #1582 )
2023-11-18 12:30:36 -05:00
krm01
0a48348f8d
doc for menkuri_eye ( #1580 )
2023-11-14 14:20:23 -05:00
Dragorn421
4c75260097
Fix misc 21 ( #1573 )
...
* Make `sNew` in (unused) `code_800FC620.c` a string
It is passed as a filename to `__osMallocDebug` so should be a nul-terminated string, not a char[3] missing an explicit \0
* Fix gcc warning in `JpegDecoder_ParseNextSymbol` about SLL on negative value
-1U is an unsigned value, aka 0xFFFFFFFF
I keep -1 because it seems that's what a jpeg standard has too
References:
https://stackoverflow.com/questions/40508958/shifting-a-negative-signed-value-is-undefined
https://www.w3.org/Graphics/JPEG/itu-t81.pdf (page 105, figure F.12)
* Small cleanup
* Fix few mistakes (thanks gcc warnings)
* Add `@bug` in file select settings draw code, using the wrong array
* format
* format main
* rename arg for a happy formatter
* Move important function call out of a printf
2023-11-12 16:59:52 -05:00
Javarooster
dc323052c3
Changed gLinkChildSlinghotStringDL to gLinkChildSlingshotStringDL ( #1576 )
2023-11-12 00:01:55 +01:00
fig02
836adb83ea
Rename "ITEM_LAST_USED" ( #1572 )
...
* rename
* format
* remove formatter changes
* change model group comments
2023-11-07 14:11:59 -05:00
fig02
042a5c5530
rename to upper action ( #1570 )
2023-11-04 02:59:12 -04:00
Dragorn421
8718a5c8c0
Remove (ActorFunc) casts in initvars ( #1571 )
...
* Remove `(ActorFunc)` casts in initvars, use `/**/` trick for format
Achieved by using the following regex:
(ActorInit.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(?:\(ActorFunc\))?(.*)(\n\s+)(?:\(ActorFunc\))?(.*)(\n\s+)(?:\(ActorFunc\))?(.*)(\n\s+)(?:\(ActorFunc\))?(.*\n\};)
replaced with
$1$2/**/ $3$4/**/ $5$6/**/ $7$8/**/ $9$10/**/ $11$12/**/ $13$14/**/ $15$16/**/ $17$18/**/ $19
plus a change from /**/ to #if 0 #endif in docs/
* Manual fixes
2023-10-30 10:19:16 -04:00
fig02
4908b8b37c
Player Docs: public facing csAction things ( #1561 )
...
* name public csAction functions
* format
* adjust function comment
* format
2023-10-28 07:46:24 -04:00
Tharo
3475651701
libc cleanup ( #1568 )
...
* libc cleanup
* Suggested changes, small alloca tweak
* Remove printf include
2023-10-27 16:06:44 +02:00
Tharo
a20163c6ab
Use long over int for s32/u32 types ( #1546 )
...
* long s32
* Suggested changes
2023-10-17 21:16:31 +02:00
cadmic
b3486b57ef
Rename Math3D_CylOutsideCyl and Math3D_CylOutsideCylDist ( #1557 )
...
* Rename Math3D_CylOutsideCyl and Math3D_CylOutsideCylDist
* radix -> radii
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* Make Math3D sphere/cylinder collision check function names more consistent
---------
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
2023-10-07 19:42:28 -04:00
fig02
181b438393
Player Docs: Propose Named Unions For Shared Variables ( #1560 )
...
* make unions
* format
* adjust comment on halt thing
2023-10-07 19:25:45 -04:00
fig02
ebc6ebf232
Player Docs: Initial AnimSfx stuff ( #1556 )
...
* initial animsfx docs
* review
* extra space
2023-10-05 10:22:40 -04:00
engineer124
c39578f971
Introduce Player CueIds ( #1559 )
...
* cueId
* cleanup
2023-10-05 10:04:41 -04:00
fig02
c5e4357127
initial action-change-list docs ( #1540 )
2023-09-27 11:02:21 -04:00
fig02
2cb4ff4fd3
Player Docs: csMode -> csAction ( #1547 )
...
* csmode -> cs action
* format
2023-09-26 12:48:41 -04:00
Derek Hensley
4d7558df0d
Speedmeter Small cleanup ( #1554 )
...
* Small cleanup
* x
2023-09-25 06:29:15 -04:00
engineer124
873c55faad
Improve Matches: Part 4 ( #1545 )
...
* more improvements
* small cleanup
* PR Review
2023-09-24 17:51:03 +02:00
Dragorn421
fefeb369dd
Name the main pause state and add placeholder enum for main (sub)states ( #1551 )
2023-09-22 14:48:09 -04:00
Dragorn421
c73e2ab726
Make macros for age reqs data and access ( #1549 )
...
* Make macros for age reqs data and access
* line breaks for readability
2023-09-22 11:50:44 -04:00
engineer124
d7f6961918
Improve Matches: Part 3 ( #1544 )
...
* improve matchings
* spacing
2023-09-20 12:41:47 -04:00
engineer124
72334df180
improve matching ( #1543 )
2023-09-20 10:54:44 -04:00
engineer124
a8d670fe5c
improve matches ( #1542 )
2023-09-20 10:41:03 -04:00
Billy
107c0288cc
Dekunut Salesman Docs ( #1493 )
...
* Dekunut Salesman Docs
* Update src/overlays/actors/ovl_En_Dns/z_en_dns.c
Remove extra param from debug logging
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* * Full Deku/Potion name usage
* Dialog -> CanBuy
* Revert debug logging symbols
* Proper declaration spacing
* Fix en_shopnuts header doc
* Biz -> Business
* Fix missed deku prefix's
* Synchronize CanBuy sticks and nuts
* Fix enum naming
* Clarified CanBuy success values
* anon review
* fig review
* macro changes
* fix macro usage
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: fig02 <fig02srl@gmail.com>
2023-09-19 21:41:42 -04:00
fig02
da3f4718f0
Player docs: Control Stick Input and Movement ( #1539 )
...
* document input stuff and movement speed+yaw
* curve -> curved, and other cleanups
* fix + format
* function declaration
* name arguments
* add mode descriptions
* fix typos
* move comment down
2023-09-19 21:37:03 -04:00
Dragorn421
185c9cbf1a
Run formatter ( #1541 )
2023-09-19 15:01:00 -04:00
Dragorn421
57ce0cf8d9
Doc/Cleanup pass on object handling ( #1227 )
...
* `Object_InitBank` -> `Object_InitContext`
* Add and use `OBJECT_SPACE_SIZE_BASE`
* Remove `OBJECT_EXCHANGE_BANK_MAX` -> use `ARRAY_COUNT()` instead
* "object status" -> "object load entry"
* Misc. cleanup/renames
* Partial docs and way too much batch renaming and cleanup for a single commit
* ctrl shift h
* format
* format clang-11.1
* fix regressions
* Improve a `@bug` comment
* Move `OBJECT_SPACE_SIZE_BASE` from header to near `Object_InitContext`
* "objectID" -> "objectId"
* Revert iterator index to `i` in `Actor_KillActorsWithUnloadedObject`
* "object load entry index" -> "object entry"
* `Object_UpdateLoadEntries` -> `Object_UpdateEntries`
* Run format.sh
* "object entry" -> "object slot" (except internal usage)
* Proper `Object_SpawnPersistent` doc
Co-authored-by: fig02 <fig02srl@gmail.com>
* fixup one comment "object bank index" -> "object slot"
* Amend `Object_SpawnPersistent` comment to mention running out of free slots
* `Actor_KillActorsWithUnloadedObject` -> `Actor_KillAllWithMissingObject`
* Remove useless mention of what uses `Object_SpawnPersistent`
* Fix mistake on `Object_SpawnPersistent` doing sync dma, not async
* run formatter
* `Object_InitContext` -> `Object_Init`
* `waitObjectSlot` -> `requiredObjectSlot`
* `Object_Init` -> `func_80097DD8`
* one objectIndex -> objectSlot
* Remove `OBJECT_SPACE_SIZE_BASE`
* light fix on the merge (rm OBJECT_EXCHANGE_BANK_MAX)
* `func_80097DD8` -> `Object_InitContext`
---------
Co-authored-by: fig02 <fig02srl@gmail.com>
2023-09-19 14:10:12 -04:00
fig02
83a13a64c7
Document niche magic spell bug ( #1526 )
...
* document magic spell bug
* Update src/overlays/actors/ovl_player_actor/z_player.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* adjust comment
* fix renamed func and reformat
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-09-19 13:23:56 -04:00
fig02
5170f2de17
Start Player Item Docs ( #1523 )
...
* item docs
* format
* loop change
* some of engineers review
* shorten comment (thanks formatter)
* ProcessItemButtons
* true/false
2023-09-18 00:08:43 -04:00
fig02
6c3e8d63cf
Name player's generic actionVars ( #1538 )
...
* name player generic vars
* format
2023-09-17 19:56:41 -04:00
Tharo
9b207c356a
Document Framebuffer Filters, VisCvg and VisZbuf ( #1534 )
...
* Document z_viscvg and z_viszbuf
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Few more notes
* Some more notes
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* Review
* Americanisation, FB RGB
* Oops
* Review
* Minor documentation modifications
* Header, base struct and enums
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* functions.h fix
* Suggested changes, further adjustments to file doc comments
* Further suggested changes, standardize capitalization of gfxP
* g
---------
Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-09-16 17:16:58 -04:00
Yanis42
239a172114
remove the extra `CS_CMD_STOP` ( #1535 )
2023-09-14 18:41:10 -04:00
fig02
823e47a0f8
Player Docs: Name actionFunc ( #1531 )
...
* progress, going to merge master
* merge master
* finish renmaing functions
* reorder declarations
2023-09-13 20:34:07 -04:00
fig02
7145bc346d
Document Camera Special9 (door) angle bug ( #1525 )
...
* document special9 angle bug
* Update src/code/z_camera.c
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-09-13 20:21:54 -04:00
Tharo
7235af2249
Apply noreturn attribute where applicable ( #1532 )
2023-09-09 10:24:52 -04:00
fig02
bedf07d541
Document Player's bgcheck routine (func_80847BA0) ( #1503 )
...
* progress
* progress
* progress
* done for now
* floor pitch comments
* sYDistToFloor
* add function comment
* sFloorShapePitch
* typo in header
2023-09-06 13:15:07 -04:00
